Bug 168914 – Add ability to configure JSC options from a file

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Michael Saboff]

JavaScriptCore has various options to alter how it operates and enable various types of logging.  These options can be set using command line options of the jsc command or via environment variables.

It would be useful, especially for devices, to set options with a configuration file.

[Michael Saboff]

<rdar://problem/30735753>

[Michael Saboff]

Created attachment 302848 [details]
Patch

[WebKit Commit Bot]

Attachment 302848 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/ConfigFile.cpp:101:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Filip Pizlo]

Looks like there are build issues, but it looks sensible to me.

[Mark Lam]

I think you need some #pragmas to resolve the build warnings.

[Mark Lam]

(In reply to comment #5)
> I think you need some #pragmas to resolve the build warnings.

Oops .. I was looking at the GTK build failure, but you actually have other ones due to type conversion.

[Michael Saboff]

Created attachment 302856 [details]
Patch with build fixes.

[WebKit Commit Bot]

Attachment 302856 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/ConfigFile.cpp:101:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Michael Saboff]

Created attachment 302906 [details]
Patch for landing - recoded the regex based JSC options white space removal code to walk through the string manually

[WebKit Commit Bot]

Attachment 302906 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/ConfigFile.cpp:100:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Michael Saboff]

Created attachment 302920 [details]
Speculative build fix for Windows

[WebKit Commit Bot]

Attachment 302920 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/ConfigFile.cpp:105:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Michael Saboff]

Created attachment 302944 [details]
Last try for a speculative windows build fix

[WebKit Commit Bot]

Attachment 302944 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/ConfigFile.cpp:105:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Michael Saboff]

Committed r213151: <http://trac.webkit.org/changeset/213151>