RESOLVED FIXED 168903
[CoordinatedGraphics] Remove CoordinatedGraphicsScene::paintToGraphicsContext() 
https://bugs.webkit.org/show_bug.cgi?id=168903
Summary [CoordinatedGraphics] Remove CoordinatedGraphicsScene::paintToGraphicsContext()
Zan Dobersek
Reported 2017-02-26 22:56:49 PST
[CoordinatedGraphics] Remove CoordinatedGraphicsScene::paintToGraphicsContext()
Attachments
Patch (6.38 KB, patch)
2017-02-26 22:58 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (6.20 KB, patch)
2017-02-26 23:24 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.23 KB, patch)
2017-02-26 23:34 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2017-02-26 22:58:58 PST
Created attachment 302819 [details] Patch
Carlos Garcia Campos
Comment 2 2017-02-26 23:07:05 PST
Comment on attachment 302819 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302819&action=review > Source/WebCore/platform/graphics/texmap/TextureMapper.cpp:47 > - : m_context(0) > - , m_interpolationQuality(InterpolationDefault) > + : m_interpolationQuality(InterpolationDefault) > , m_textDrawingMode(TextModeFill) > , m_isMaskMode(false) > , m_wrapMode(StretchWrap) Maybe it's a good moment to move this to the ceclaration?
Zan Dobersek
Comment 3 2017-02-26 23:24:14 PST
Created attachment 302822 [details] Patch
Zan Dobersek
Comment 4 2017-02-26 23:26:38 PST
(In reply to comment #2) > Comment on attachment 302819 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=302819&action=review > > > Source/WebCore/platform/graphics/texmap/TextureMapper.cpp:47 > > - : m_context(0) > > - , m_interpolationQuality(InterpolationDefault) > > + : m_interpolationQuality(InterpolationDefault) > > , m_textDrawingMode(TextModeFill) > > , m_isMaskMode(false) > > , m_wrapMode(StretchWrap) > > Maybe it's a good moment to move this to the ceclaration? I think at least the interpolation quality and wrap mode can be removed. I'll post another patch.
Zan Dobersek
Comment 5 2017-02-26 23:34:11 PST
Created attachment 302823 [details] Patch for landing
Zan Dobersek
Comment 6 2017-02-27 00:01:05 PST
Comment on attachment 302823 [details] Patch for landing Clearing flags on attachment: 302823 Committed r213035: <http://trac.webkit.org/changeset/213035>
Zan Dobersek
Comment 7 2017-02-27 00:01:14 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.