Bug 168903 - [CoordinatedGraphics] Remove CoordinatedGraphicsScene::paintToGraphicsContext()
Summary: [CoordinatedGraphics] Remove CoordinatedGraphicsScene::paintToGraphicsContext()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-26 22:56 PST by Zan Dobersek
Modified: 2017-02-27 00:01 PST (History)
0 users

See Also:

Attachments
Patch (6.38 KB, patch)
2017-02-26 22:58 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (6.20 KB, patch)
2017-02-26 23:24 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch for landing (6.23 KB, patch)
2017-02-26 23:34 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2017-02-26 22:56:49 PST 
[CoordinatedGraphics] Remove CoordinatedGraphicsScene::paintToGraphicsContext()
Comment 1 Zan Dobersek 2017-02-26 22:58:58 PST 
Created attachment 302819 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-02-26 23:07:05 PST 
Comment on attachment 302819 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302819&action=review

> Source/WebCore/platform/graphics/texmap/TextureMapper.cpp:47
> -    : m_context(0)
> -    , m_interpolationQuality(InterpolationDefault)
> +    : m_interpolationQuality(InterpolationDefault)
>      , m_textDrawingMode(TextModeFill)
>      , m_isMaskMode(false)
>      , m_wrapMode(StretchWrap)

Maybe it's a good moment to move this to the ceclaration?
Comment 3 Zan Dobersek 2017-02-26 23:24:14 PST 
Created attachment 302822 [details]
Patch
Comment 4 Zan Dobersek 2017-02-26 23:26:38 PST 
(In reply to comment #2)
> Comment on attachment 302819 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=302819&action=review
> 
> > Source/WebCore/platform/graphics/texmap/TextureMapper.cpp:47
> > -    : m_context(0)
> > -    , m_interpolationQuality(InterpolationDefault)
> > +    : m_interpolationQuality(InterpolationDefault)
> >      , m_textDrawingMode(TextModeFill)
> >      , m_isMaskMode(false)
> >      , m_wrapMode(StretchWrap)
> 
> Maybe it's a good moment to move this to the ceclaration?

I think at least the interpolation quality and wrap mode can be removed. I'll post another patch.
Comment 5 Zan Dobersek 2017-02-26 23:34:11 PST 
Created attachment 302823 [details]
Patch for landing
Comment 6 Zan Dobersek 2017-02-27 00:01:05 PST 
Comment on attachment 302823 [details]
Patch for landing

Clearing flags on attachment: 302823

Committed r213035: <http://trac.webkit.org/changeset/213035>
Comment 7 Zan Dobersek 2017-02-27 00:01:14 PST 
All reviewed patches have been landed.  Closing bug.