Bug 168885 - Stop exporting C++ member variables from WKDOMTextIterator
Summary: Stop exporting C++ member variables from WKDOMTextIterator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-26 20:06 PST by Alexey Proskuryakov
Modified: 2017-02-26 21:22 PST (History)
4 users (show)

See Also:


Attachments
proposed patch (1.12 KB, patch)
2017-02-26 20:07 PST, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2017-02-26 20:06:19 PST
Having these as public variables results in exporting symbols from the binary. As far as I can tell, there is no reason for them to be public.
Comment 1 Alexey Proskuryakov 2017-02-26 20:07:32 PST
Created attachment 302802 [details]
proposed patch
Comment 2 WebKit Commit Bot 2017-02-26 21:22:07 PST
Comment on attachment 302802 [details]
proposed patch

Clearing flags on attachment: 302802

Committed r213023: <http://trac.webkit.org/changeset/213023>
Comment 3 WebKit Commit Bot 2017-02-26 21:22:11 PST
All reviewed patches have been landed.  Closing bug.