Bug 168877 - Remove spurious C++ includes from WebKit2 SPI headers
Summary: Remove spurious C++ includes from WebKit2 SPI headers
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
Depends on:
Reported: 2017-02-25 19:55 PST by Alexey Proskuryakov
Modified: 2017-02-26 16:56 PST (History)
4 users (show)

See Also:

proposed fix (1.49 KB, patch)
2017-02-25 19:56 PST, Alexey Proskuryakov
mitz: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews112 for mac-elcapitan (1.69 MB, application/zip)
2017-02-25 21:09 PST, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2017-02-25 19:55:12 PST
There are some random unneeded includes.
Comment 1 Alexey Proskuryakov 2017-02-25 19:56:23 PST
Created attachment 302769 [details]
proposed fix
Comment 2 Build Bot 2017-02-25 21:09:56 PST
Comment on attachment 302769 [details]
proposed fix

Attachment 302769 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3194338

New failing tests:
Comment 3 Build Bot 2017-02-25 21:09:59 PST
Created attachment 302773 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 WebKit Commit Bot 2017-02-26 16:19:15 PST
Comment on attachment 302769 [details]
proposed fix

Rejecting attachment 302769 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 302769, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit2/UIProcess/API/C/WKResourceLoadStatisticsManager.h
Hunk #1 FAILED at 26.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit2/UIProcess/API/C/WKResourceLoadStatisticsManager.h.rej
patching file Source/WebKit2/UIProcess/API/Cocoa/_WKTestingDelegate.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Dan Bernstein']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/3198576
Comment 5 Alexey Proskuryakov 2017-02-26 16:56:27 PST
Committed http://trac.webkit.org/r213021 (one of the changes was accidentally included in another patch that landed earlier).