RESOLVED FIXED 168864
Text might wrap when its preferred logical width is used for sizing the containing block. 
https://bugs.webkit.org/show_bug.cgi?id=168864
Summary Text might wrap when its preferred logical width is used for sizing the conta...
zalan
Reported 2017-02-24 21:26:33 PST
<rdar://problem/30690734>
Attachments
Patch (5.48 KB, patch)
2017-02-24 22:01 PST, zalan 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews112 for mac-elcapitan (1.70 MB, application/zip)
2017-02-24 23:49 PST, Build Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2017-02-24 22:01:45 PST
Created attachment 302734 [details] Patch
zalan
Comment 2 2017-02-24 22:02:40 PST
Alternative solutions are welcome!
Build Bot
Comment 3 2017-02-24 23:49:48 PST
Comment on attachment 302734 [details] Patch Attachment 302734 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3189792 New failing tests: media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button.html
Build Bot
Comment 4 2017-02-24 23:49:52 PST
Created attachment 302745 [details] Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
zalan
Comment 5 2017-02-25 06:14:51 PST
Comment on attachment 302745 [details] Archive of layout-test-results from ews112 for mac-elcapitan Timeouts -> totally unrelated.
WebKit Commit Bot
Comment 6 2017-02-25 14:20:13 PST
Comment on attachment 302734 [details] Patch Clearing flags on attachment: 302734 Committed r213008: <http://trac.webkit.org/changeset/213008>
WebKit Commit Bot
Comment 7 2017-02-25 14:20:18 PST
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 8 2017-02-27 08:50:03 PST
Comment on attachment 302734 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302734&action=review > Source/WebCore/platform/graphics/FontCascade.cpp:386 > + if (text.isNull() || text.isEmpty()) > + return 0; Checking isNull is redundant. If it's null, then it's also empty.
Note You need to log in before you can comment on or make changes to this bug.