Add a way to test file input without relying on drag and drop
rdar://problem/22258242
Created attachment 302693 [details] Patch
Comment on attachment 302693 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302693&action=review > Tools/DumpRenderTree/mac/UIDelegate.mm:368 > + printf("OPEN FILE PANEL\n"); I don't think you meant to include this.
(In reply to comment #3) > Comment on attachment 302693 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=302693&action=review > > > Tools/DumpRenderTree/mac/UIDelegate.mm:368 > > + printf("OPEN FILE PANEL\n"); > > I don't think you meant to include this. I did, actually. It matches the existing logging we had in WebKitTestRunner's UI delegate. Thanks for the review!
(In reply to comment #4) > (In reply to comment #3) > > Comment on attachment 302693 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=302693&action=review > > > > > Tools/DumpRenderTree/mac/UIDelegate.mm:368 > > > + printf("OPEN FILE PANEL\n"); > > > > I don't think you meant to include this. > > I did, actually. It matches the existing logging we had in > WebKitTestRunner's UI delegate. > > Thanks for the review! Heh! OK.
Created attachment 302707 [details] Patch
Comment on attachment 302707 [details] Patch Attachment 302707 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3188431 New failing tests: fast/events/domactivate-sets-underlying-click-event-as-handled.html accessibility/axpress-on-aria-button.html accessibility/file-upload-button-with-axpress.html
Created attachment 302725 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 302707 [details] Patch Attachment 302707 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3188535 New failing tests: fast/events/domactivate-sets-underlying-click-event-as-handled.html accessibility/axpress-on-aria-button.html accessibility/file-upload-button-with-axpress.html
Created attachment 302726 [details] Archive of layout-test-results from ews115 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 302707 [details] Patch Attachment 302707 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3188429 New failing tests: http/tests/local/fileapi/file-last-modified-after-delete-using-open-panel.html fast/files/apply-blob-url-to-xhr-using-open-panel.html http/tests/local/formdata/send-form-data-with-empty-file-filename-using-open-panel.html fast/files/file-reader-abort-using-open-panel.html media/video-src-blob-using-open-panel.html fast/files/apply-blob-url-to-img-using-open-panel.html fast/forms/file/input-file-value-using-open-panel.html http/tests/local/blob/send-hybrid-blob-using-open-panel.html fast/forms/file/input-file-write-files-using-open-panel.html fast/files/file-list-test-using-open-panel.html fast/history/page-cache-createObjectURL-using-open-panel.html fast/dom/FileList-iterator-using-open-panel.html fast/forms/file/file-input-reset-using-open-panel.html http/tests/local/formdata/send-form-data-constructed-from-form-using-open-panel.html http/tests/local/fileapi/file-last-modified-using-open-panel.html fast/forms/file/file-reset-in-change-using-open-panel.html fast/files/file-reader-directory-crash-using-open-panel.html fast/forms/file/get-file-upload-using-open-panel.html
Created attachment 302729 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 302707 [details] Patch Attachment 302707 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3189004 New failing tests: http/tests/local/fileapi/file-last-modified-after-delete-using-open-panel.html fast/files/apply-blob-url-to-xhr-using-open-panel.html http/tests/local/formdata/send-form-data-with-empty-file-filename-using-open-panel.html fast/files/file-reader-abort-using-open-panel.html fast/forms/file/input-file-write-files-using-open-panel.html media/video-src-blob-using-open-panel.html fast/files/apply-blob-url-to-img-using-open-panel.html fast/forms/file/input-file-value-using-open-panel.html http/tests/local/blob/send-hybrid-blob-using-open-panel.html fast/files/file-reader-directory-crash-using-open-panel.html fast/files/file-list-test-using-open-panel.html http/tests/local/fileapi/file-last-modified-using-open-panel.html fast/forms/file/file-input-reset-using-open-panel.html http/tests/local/formdata/send-form-data-constructed-from-form-using-open-panel.html fast/history/page-cache-createObjectURL-using-open-panel.html fast/forms/file/file-reset-in-change-using-open-panel.html fast/dom/FileList-iterator-using-open-panel.html fast/forms/file/get-file-upload-using-open-panel.html
Created attachment 302733 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Created attachment 302799 [details] Patch
Comment on attachment 302799 [details] Patch Rejecting attachment 302799 [details] from commit-queue. New failing tests: media/modern-media-controls/volume-down-support/volume-down-support.html Full output: http://webkit-queues.webkit.org/results/3199114
Created attachment 302801 [details] Archive of layout-test-results from webkit-cq-01 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-01 Port: mac-elcapitan Platform: Mac OS X 10.11.6
(In reply to comment #13) > Comment on attachment 302707 [details] > Patch > > Attachment 302707 [details] did not pass ios-sim-ews (ios-simulator-wk2): > Output: http://webkit-queues.webkit.org/results/3189004 > > New failing tests: > http/tests/local/fileapi/file-last-modified-after-delete-using-open-panel. > html > fast/files/apply-blob-url-to-xhr-using-open-panel.html > http/tests/local/formdata/send-form-data-with-empty-file-filename-using-open- > panel.html > fast/files/file-reader-abort-using-open-panel.html > fast/forms/file/input-file-write-files-using-open-panel.html > media/video-src-blob-using-open-panel.html > fast/files/apply-blob-url-to-img-using-open-panel.html > fast/forms/file/input-file-value-using-open-panel.html > http/tests/local/blob/send-hybrid-blob-using-open-panel.html > fast/files/file-reader-directory-crash-using-open-panel.html > fast/files/file-list-test-using-open-panel.html > http/tests/local/fileapi/file-last-modified-using-open-panel.html > fast/forms/file/file-input-reset-using-open-panel.html > http/tests/local/formdata/send-form-data-constructed-from-form-using-open- > panel.html > fast/history/page-cache-createObjectURL-using-open-panel.html > fast/forms/file/file-reset-in-change-using-open-panel.html > fast/dom/FileList-iterator-using-open-panel.html > fast/forms/file/get-file-upload-using-open-panel.html These timeouts will be fixed by https://bugs.webkit.org/show_bug.cgi?id=141906
Created attachment 302827 [details] Patch
Created attachment 302828 [details] Patch
Comment on attachment 302828 [details] Patch Clearing flags on attachment: 302828 Committed r213042: <http://trac.webkit.org/changeset/213042>
All reviewed patches have been landed. Closing bug.