Bug 168846 - [css-align] Implement the place-self shorthand
Summary: [css-align] Implement the place-self shorthand
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Javier Fernandez
URL:
Keywords: WebExposed
Depends on:
Blocks: 168845
  Show dependency treegraph
 
Reported: 2017-02-24 14:32 PST by Javier Fernandez
Modified: 2017-05-13 14:37 PDT (History)
10 users (show)

See Also:


Attachments
Patch (20.59 KB, patch)
2017-05-05 06:50 PDT, Javier Fernandez
no flags Details | Formatted Diff | Diff
Patch (20.58 KB, patch)
2017-05-05 07:48 PDT, Javier Fernandez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-elcapitan (751.52 KB, application/zip)
2017-05-05 09:02 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (841.03 KB, application/zip)
2017-05-05 09:08 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews117 for mac-elcapitan (1.77 MB, application/zip)
2017-05-05 09:17 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (916.01 KB, application/zip)
2017-05-05 09:31 PDT, Build Bot
no flags Details
Patch (20.25 KB, patch)
2017-05-10 05:05 PDT, Javier Fernandez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Javier Fernandez 2017-02-24 14:32:25 PST
Spec: 

https://drafts.csswg.org/css-align/#place-self-property
 
Note that the syntax has just been discussed on the CSS WG.

Check the last comments on this issue before implementing them:
https://github.com/w3c/csswg-drafts/issues/595#issuecomment-262709407
Comment 1 Javier Fernandez 2017-05-05 06:50:41 PDT
Created attachment 309167 [details]
Patch
Comment 2 Javier Fernandez 2017-05-05 07:48:17 PDT
Created attachment 309168 [details]
Patch
Comment 3 Build Bot 2017-05-05 09:02:48 PDT
Comment on attachment 309168 [details]
Patch

Attachment 309168 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3679472

New failing tests:
css3/parse-place-self.html
Comment 4 Build Bot 2017-05-05 09:02:50 PDT
Created attachment 309171 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 5 Build Bot 2017-05-05 09:08:29 PDT
Comment on attachment 309168 [details]
Patch

Attachment 309168 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3679478

New failing tests:
css3/parse-place-self.html
Comment 6 Build Bot 2017-05-05 09:08:30 PDT
Created attachment 309172 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 7 Build Bot 2017-05-05 09:17:48 PDT
Comment on attachment 309168 [details]
Patch

Attachment 309168 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3679481

New failing tests:
css3/parse-place-self.html
Comment 8 Build Bot 2017-05-05 09:17:50 PDT
Created attachment 309174 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 9 Build Bot 2017-05-05 09:31:00 PDT
Comment on attachment 309168 [details]
Patch

Attachment 309168 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3679499

New failing tests:
css3/parse-place-self.html
Comment 10 Build Bot 2017-05-05 09:31:02 PDT
Created attachment 309177 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 11 Javier Fernandez 2017-05-10 05:05:44 PDT
Created attachment 309590 [details]
Patch
Comment 12 WebKit Commit Bot 2017-05-13 14:37:02 PDT
Comment on attachment 309590 [details]
Patch

Clearing flags on attachment: 309590

Committed r216829: <http://trac.webkit.org/changeset/216829>
Comment 13 WebKit Commit Bot 2017-05-13 14:37:04 PDT
All reviewed patches have been landed.  Closing bug.