Bug 168840 - Media: notify clients when autoplay is denied
Summary: Media: notify clients when autoplay is denied
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-24 12:58 PST by Matt Rajca
Modified: 2017-02-27 08:46 PST (History)
0 users

See Also:

Attachments
Patch (23.73 KB, patch)
2017-02-24 13:02 PST, Matt Rajca 		achristensen: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Rajca 2017-02-24 12:58:18 PST 
Tell clients when autoplay is denied due to restrictions.
Comment 1 Matt Rajca 2017-02-24 13:02:17 PST 
Created attachment 302680 [details]
Patch
Comment 2 Alex Christensen 2017-02-24 13:49:50 PST 
Comment on attachment 302680 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302680&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:2425
> +            if (Page* page = document().page())

Darin would say "auto*"

> Source/WebCore/page/AutoplayEvent.h:30
> +enum {

I think we should make this enum class AutoplayEvent and cast it to uint32_t for IPC.
Comment 3 Matt Rajca 2017-02-24 15:08:51 PST 
(In reply to comment #2)
> Comment on attachment 302680 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=302680&action=review
> 
> > Source/WebCore/html/HTMLMediaElement.cpp:2425
> > +            if (Page* page = document().page())
> 
> Darin would say "auto*"
> 
> > Source/WebCore/page/AutoplayEvent.h:30
> > +enum {
> 
> I think we should make this enum class AutoplayEvent and cast it to uint32_t
> for IPC.

Done.
Comment 4 Matt Rajca 2017-02-27 08:46:48 PST 
Committed: r212982