Bug 168836 – WebAssembly: validate load / store alignment

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[JF Bastien]

From https://github.com/WebAssembly/design/blob/master/BinaryEncoding.md#memory-related-operators-described-here

    As implied by the log2(alignment) encoding, the alignment must be a power of 2. As an additional validation criteria, the alignment must be less or equal to natural alignment. The bits after the log(memory-access-size) least-significant bits must be set to 0. These bits are reserved for future 🦄 use (e.g., for shared memory ordering requirements).


We currently don't check this. I'll add FIXME in the code, and comment out related spec tests with FIXME as well.

We should get this information from the JSON file, and auto-generate it in generateWasmOpsHeader.py.

[Radar WebKit Bug Importer]

<rdar://problem/31965349>

[JF Bastien]

Created attachment 309878 [details]
patch

[Build Bot]

This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json".

[Keith Miller]

Comment on attachment 309878 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309878&action=review

r=me. with nit... maybe?

> Source/JavaScriptCore/wasm/generateWasm.py:105
> +    return str(int(math.log(memoryBits, 2)))

nit: math.log doesn't return an int? O.o

[JF Bastien]

(In reply to Keith Miller from comment #4)
> Comment on attachment 309878 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=309878&action=review
> 
> r=me. with nit... maybe?
> 
> > Source/JavaScriptCore/wasm/generateWasm.py:105
> > +    return str(int(math.log(memoryBits, 2)))
> 
> nit: math.log doesn't return an int? O.o

No.

[WebKit Commit Bot]

Comment on attachment 309878 [details]
patch

Clearing flags on attachment: 309878

Committed r216908: <http://trac.webkit.org/changeset/216908>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.