Disable network cache speculative revalidation / loading in low power mode on iOS to save battery.
<rdar://problem/30697911>
Created attachment 302676 [details] Patch
Comment on attachment 302676 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302676&action=review > Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:85 > + m_speculativeLoadManager = nullptr; Have you verified that SpeculativeLoadManager can deal with being deleted while having ongoing requests? I think it is a new scenario. It could be tested with simulated repeated switches to low power and back while browsing.
(In reply to comment #3) > Comment on attachment 302676 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=302676&action=review > > > Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:85 > > + m_speculativeLoadManager = nullptr; > > Have you verified that SpeculativeLoadManager can deal with being deleted > while having ongoing requests? I think it is a new scenario. It could be > tested with simulated repeated switches to low power and back while browsing. I'll try with simulated switches. I tried with manual ones but triggering them during a load is not super easy.
Comment on attachment 302676 [details] Patch Clearing flags on attachment: 302676 Committed r212965: <http://trac.webkit.org/changeset/212965>
All reviewed patches have been landed. Closing bug.