Bug 168821 – REGRESSION (r211312): Double-clicking a word selects it along with the space that follows it

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

To reproduce this bug, double-click the second word in this sentence. Only the word should be selected, but instead, the word is selected along with the space that follows it.

<rdar://problem/30690431>

Caused by <https://trac.webkit.org/r211312>, the fix for bug 167530.

Wenson Hsieh found the problem: “adding smartInsertDeleteEnabled to WebPageCreationParameters::encode and WebPageCreationParameters::decode fixes the  problem for me”.

[Wenson Hsieh]

Created attachment 302756 [details]
Patch

[Wenson Hsieh]

Comment on attachment 302756 [details]
Patch

Thanks Tim!

[WebKit Commit Bot]

Comment on attachment 302756 [details]
Patch

Rejecting attachment 302756 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 302756, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
s/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj.rej
patching file Tools/TestWebKitAPI/Tests/WebKit2Cocoa/double-click-does-not-select-trailing-space.html
patching file Tools/TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm
patching file Tools/TestWebKitAPI/cocoa/TestWKWebView.h
patching file Tools/TestWebKitAPI/cocoa/TestWKWebView.mm

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Tim Horton']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/3198114

[Wenson Hsieh]

Created attachment 302791 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 302791 [details]
Patch for landing

Clearing flags on attachment: 302791

Committed r213012: <http://trac.webkit.org/changeset/213012>