Bug 168821 - REGRESSION (r211312): Double-clicking a word selects it along with the space that follows it
Summary: REGRESSION (r211312): Double-clicking a word selects it along with the space ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2017-02-23 21:19 PST by mitz
Modified: 2017-02-26 15:22 PST (History)
7 users (show)

See Also:

Attachments
Patch (16.49 KB, patch)
2017-02-25 02:11 PST, Wenson Hsieh 		thorton: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (16.60 KB, patch)
2017-02-26 14:28 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2017-02-23 21:19:28 PST 
To reproduce this bug, double-click the second word in this sentence. Only the word should be selected, but instead, the word is selected along with the space that follows it.
Comment 1 mitz 2017-02-24 10:17:01 PST 
<rdar://problem/30690431>

Caused by <https://trac.webkit.org/r211312>, the fix for bug 167530.
Comment 2 mitz 2017-02-24 14:39:36 PST 
Wenson Hsieh found the problem: “adding smartInsertDeleteEnabled to WebPageCreationParameters::encode and WebPageCreationParameters::decode fixes the  problem for me”.
Comment 3 Wenson Hsieh 2017-02-25 02:11:43 PST 
Created attachment 302756 [details]
Patch
Comment 4 Wenson Hsieh 2017-02-26 14:21:47 PST 
Comment on attachment 302756 [details]
Patch

Thanks Tim!
Comment 5 WebKit Commit Bot 2017-02-26 14:23:40 PST 
Comment on attachment 302756 [details]
Patch

Rejecting attachment 302756 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 302756, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
s/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj.rej
patching file Tools/TestWebKitAPI/Tests/WebKit2Cocoa/double-click-does-not-select-trailing-space.html
patching file Tools/TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm
patching file Tools/TestWebKitAPI/cocoa/TestWKWebView.h
patching file Tools/TestWebKitAPI/cocoa/TestWKWebView.mm

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Tim Horton']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/3198114
Comment 6 Wenson Hsieh 2017-02-26 14:28:48 PST 
Created attachment 302791 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2017-02-26 15:08:45 PST 
Comment on attachment 302791 [details]
Patch for landing

Clearing flags on attachment: 302791

Committed r213012: <http://trac.webkit.org/changeset/213012>