Bug 168818 - [Modern Media Controls] Controls overflow when media element has border or padding
Summary: [Modern Media Controls] Controls overflow when media element has border or pa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-23 20:09 PST by Antoine Quint
Modified: 2017-02-23 22:42 PST (History)
4 users (show)

See Also:

Attachments
Patch (15.43 KB, patch)
2017-02-23 20:13 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (882.61 KB, application/zip)
2017-02-23 21:22 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews116 for mac-elcapitan (1.52 MB, application/zip)
2017-02-23 21:26 PST, Build Bot 		no flags Details
Patch for landing (16.14 KB, patch)
2017-02-23 22:03 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2017-02-23 20:09:32 PST 
If the media element has border or padding, the media controls aren't sized to match the video size and overflow.
Comment 1 Radar WebKit Bug Importer 2017-02-23 20:09:47 PST 
<rdar://problem/30689780>
Comment 2 Antoine Quint 2017-02-23 20:13:00 PST 
Created attachment 302632 [details]
Patch
Comment 3 Build Bot 2017-02-23 21:22:19 PST 
Comment on attachment 302632 [details]
Patch

Attachment 302632 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3182991

New failing tests:
media/track/track-cue-rendering-snap-to-lines-not-set.html
Comment 4 Build Bot 2017-02-23 21:22:22 PST 
Created attachment 302638 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 5 Build Bot 2017-02-23 21:26:03 PST 
Comment on attachment 302632 [details]
Patch

Attachment 302632 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3182989

New failing tests:
media/track/track-cue-rendering-snap-to-lines-not-set.html
media/track/track-in-band-style.html
Comment 6 Build Bot 2017-02-23 21:26:05 PST 
Created attachment 302639 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 7 Antoine Quint 2017-02-23 22:03:08 PST 
Created attachment 302642 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2017-02-23 22:42:17 PST 
Comment on attachment 302642 [details]
Patch for landing

Clearing flags on attachment: 302642

Committed r212943: <http://trac.webkit.org/changeset/212943>
Comment 9 WebKit Commit Bot 2017-02-23 22:42:21 PST 
All reviewed patches have been landed.  Closing bug.