Bug 168816 – Rename 'commit_parent' in 'commits' table to 'commit_previous_commit'.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

Rename 'commit_parent' in 'commits' table to 'commit_previous_commit'.

Created attachment 302630 [details]
Patch

[Chris Dumez]

commit_previous_commit ? What does it mean?

[Ryosuke Niwa]

Comment on attachment 302630 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302630&action=review

r=me with previous_commit > previousCommit in JSON API.

> Websites/perf.webkit.org/public/include/commit-log-fetcher.php:124
> -            'parent' => $commit_row['commit_parent'],
> +            'previous_commit' => $commit_row['commit_previous_commit'],

We should be using camelCase for JSON API.

> Websites/perf.webkit.org/tools/sync-commits.py:234
> -            'parent': parent_hash,
> +            'previous_commit': previous_hash,

This should also be previousCommit.

[Ryosuke Niwa]

(In reply to comment #2)
> commit_previous_commit ? What does it mean?

In subversion, the previous commit of a revision X is X - 1. In git, the previous commit of a commit X is the parent commit.

Because we're introducing the concept of a repository having a parent/owner repository, we're changing this column to be more semantically clear as to what it means.

We can also call it preceding commit but that doesn't make much sense in Git world.

Created attachment 302644 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 302644 [details]
Patch for landing

Clearing flags on attachment: 302644

Committed r212947: <http://trac.webkit.org/changeset/212947>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryosuke Niwa]

Confirmed this works on a local copy of the production database on my machine.