Bug 168808 - Web Inspector: RTL: add support for Styles - Visual sidebar
Summary: Web Inspector: RTL: add support for Styles - Visual sidebar
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-23 16:21 PST by Devin Rousso
Modified: 2018-10-25 01:28 PDT (History)
3 users (show)

See Also:


Attachments
[Image] Screenshot of Issue (30.34 KB, image/png)
2017-02-23 16:21 PST, Devin Rousso
no flags Details
Patch (53.25 KB, patch)
2017-02-24 16:06 PST, Devin Rousso
no flags Details | Formatted Diff | Diff
[Image] After Patch is applied (60.60 KB, image/png)
2017-02-24 16:07 PST, Devin Rousso
no flags Details
Patch (54.43 KB, patch)
2017-04-04 23:08 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
[Image] After Patch is applied (68.15 KB, image/png)
2017-04-04 23:09 PDT, Devin Rousso
no flags Details
Patch (43.67 KB, patch)
2017-09-27 14:53 PDT, Devin Rousso
bburg: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2017-02-23 16:21:07 PST
Created attachment 302603 [details]
[Image] Screenshot of Issue

.
Comment 1 Devin Rousso 2017-02-24 16:06:59 PST
Created attachment 302697 [details]
Patch
Comment 2 Devin Rousso 2017-02-24 16:07:28 PST
Created attachment 302698 [details]
[Image] After Patch is applied
Comment 3 BJ Burg 2017-02-24 22:17:36 PST
Comment on attachment 302697 [details]
Patch

Directions like left, right that are also CSS properties should not be flipped if used in a visual orientation where left is leftmost and right is rightmost. I see this in the screenshot for the absolute positioning offset properties and margin-left, padding-left, etc.
Comment 4 Radar WebKit Bug Importer 2017-04-02 09:48:33 PDT
<rdar://problem/31393671>
Comment 5 Devin Rousso 2017-04-04 23:08:40 PDT
Created attachment 306260 [details]
Patch
Comment 6 Devin Rousso 2017-04-04 23:09:06 PDT
Created attachment 306261 [details]
[Image] After Patch is applied
Comment 7 BJ Burg 2017-04-05 11:29:54 PDT
(In reply to Devin Rousso from comment #6)
> Created attachment 306261 [details]
> [Image] After Patch is applied

This is looking much better. I'll take it for a spin with Arabic localization to see if the editing makes sense.

This sidebar is a bit of a grey area because some of the visual editors take CSS syntax as input which should always be LTR. Others are more direct-manipulation or wrap CSS values with UI, which is more open to RTL interpretation.
Comment 8 Devin Rousso 2017-09-27 14:53:32 PDT
Created attachment 322021 [details]
Patch
Comment 9 BJ Burg 2017-09-28 14:24:47 PDT
Comment on attachment 322021 [details]
Patch

I sent out some functional review comments via email with screenshots. When those are addressed I'll review the patch.
Comment 10 Devin Rousso 2018-10-25 01:28:26 PDT
The Visual styles sidebar was removed in r236298 <https://webkit.org/b/189807>.