Bug 168807 - Web Inspector: RTL: Styles - Rules sidebar icons are misaligned
Summary: Web Inspector: RTL: Styles - Rules sidebar icons are misaligned
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-23 15:55 PST by Devin Rousso
Modified: 2017-02-25 00:10 PST (History)
4 users (show)

See Also:

Attachments
[Image] Screenshot of Issue (88.37 KB, image/png)
2017-02-23 15:55 PST, Devin Rousso 		no flags Details
Patch (9.67 KB, patch)
2017-02-23 16:18 PST, Devin Rousso 		bburg: review+
bburg: commit-queue-
Details | Formatted Diff | Diff
[Image] After Patch is applied (98.03 KB, image/png)
2017-02-23 16:18 PST, Devin Rousso 		no flags Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (1.90 MB, application/zip)
2017-02-23 17:10 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews117 for mac-elcapitan (1.69 MB, application/zip)
2017-02-23 17:33 PST, Build Bot 		no flags Details
Patch (9.66 KB, patch)
2017-02-24 23:39 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2017-02-23 15:55:09 PST 
Created attachment 302597 [details]
[Image] Screenshot of Issue

.
Comment 1 Devin Rousso 2017-02-23 16:18:22 PST 
Created attachment 302601 [details]
Patch
Comment 2 Devin Rousso 2017-02-23 16:18:50 PST 
Created attachment 302602 [details]
[Image] After Patch is applied
Comment 3 Build Bot 2017-02-23 17:10:05 PST 
Comment on attachment 302601 [details]
Patch

Attachment 302601 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3181917

New failing tests:
media/modern-media-controls/volume-down-support/volume-down-support.html
Comment 4 Build Bot 2017-02-23 17:10:08 PST 
Created attachment 302612 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 5 Build Bot 2017-02-23 17:33:01 PST 
Comment on attachment 302601 [details]
Patch

Attachment 302601 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3181970

New failing tests:
media/modern-media-controls/volume-down-support/volume-down-support.html
Comment 6 Build Bot 2017-02-23 17:33:03 PST 
Created attachment 302617 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 7 BJ Burg 2017-02-24 22:05:34 PST 
Comment on attachment 302601 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302601&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.css:101
> +    left: var(--style-declaration-section-header-icon-start);

Nit: should be 'offset-start'.

> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.css:139
> +    margin: 4px var(--style-declaration-section-header-padding-end) 3px var(--style-declaration-section-header-padding-start);

Please use a different variable specific to margins unless there is an arithmetic relation between the two. You can even define one in terms of the other if they must remain synced.
Comment 8 Devin Rousso 2017-02-24 23:39:03 PST 
Created attachment 302743 [details]
Patch
Comment 9 WebKit Commit Bot 2017-02-25 00:10:17 PST 
Comment on attachment 302743 [details]
Patch

Clearing flags on attachment: 302743

Committed r212999: <http://trac.webkit.org/changeset/212999>
Comment 10 WebKit Commit Bot 2017-02-25 00:10:22 PST 
All reviewed patches have been landed.  Closing bug.