Bug 168807 – Web Inspector: RTL: Styles - Rules sidebar icons are misaligned

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

Created attachment 302597 [details]
[Image] Screenshot of Issue

.

[Devin Rousso]

Created attachment 302601 [details]
Patch

[Devin Rousso]

Created attachment 302602 [details]
[Image] After Patch is applied

[Build Bot]

Comment on attachment 302601 [details]
Patch

Attachment 302601 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3181917

New failing tests:
media/modern-media-controls/volume-down-support/volume-down-support.html

[Build Bot]

Created attachment 302612 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 302601 [details]
Patch

Attachment 302601 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3181970

New failing tests:
media/modern-media-controls/volume-down-support/volume-down-support.html

[Build Bot]

Created attachment 302617 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Blaze Burg]

Comment on attachment 302601 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302601&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.css:101
> +    left: var(--style-declaration-section-header-icon-start);

Nit: should be 'offset-start'.

> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.css:139
> +    margin: 4px var(--style-declaration-section-header-padding-end) 3px var(--style-declaration-section-header-padding-start);

Please use a different variable specific to margins unless there is an arithmetic relation between the two. You can even define one in terms of the other if they must remain synced.

[Devin Rousso]

Created attachment 302743 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 302743 [details]
Patch

Clearing flags on attachment: 302743

Committed r212999: <http://trac.webkit.org/changeset/212999>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.