Bug 168797 – [Mac] Report domains using abnormally high memory usage via enhanced privacy logging

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Chris Dumez]

Report domains using abnormally high memory usage (> 2GB) via enhanced privacy logging on Mac.

[Chris Dumez]

<rdar://problem/29964017>

[Chris Dumez]

Created attachment 302567 [details]
Patch

[Build Bot]

Comment on attachment 302567 [details]
Patch

Attachment 302567 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3181783

New failing tests:
fast/dom/timer-throttling-hidden-page-non-nested.html

[Build Bot]

Created attachment 302607 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Andreas Kling]

Comment on attachment 302567 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302567&action=review

r=me

> Source/WebCore/page/DiagnosticLoggingKeys.cpp:353
> +    return ASCIILiteral("DomainCausingJetsam");

This seems like a bit of a misnomer, since it's not actually causing jetsam.
DomainCausingHighMemoryUsage?

[Chris Dumez]

(In reply to comment #5)
> Comment on attachment 302567 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=302567&action=review
> 
> r=me
> 
> > Source/WebCore/page/DiagnosticLoggingKeys.cpp:353
> > +    return ASCIILiteral("DomainCausingJetsam");
> 
> This seems like a bit of a misnomer, since it's not actually causing jetsam.
> DomainCausingHighMemoryUsage?

It is not up to me, this IS the key we got assigned.

[Chris Dumez]

(In reply to comment #6)
> (In reply to comment #5)
> > Comment on attachment 302567 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=302567&action=review
> > 
> > r=me
> > 
> > > Source/WebCore/page/DiagnosticLoggingKeys.cpp:353
> > > +    return ASCIILiteral("DomainCausingJetsam");
> > 
> > This seems like a bit of a misnomer, since it's not actually causing jetsam.
> > DomainCausingHighMemoryUsage?
> 
> It is not up to me, this IS the key we got assigned.

See radar for assigned key.

[Chris Dumez]

Comment on attachment 302567 [details]
Patch

Clearing flags on attachment: 302567

Committed r212961: <http://trac.webkit.org/changeset/212961>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.