Bug 168797 - [Mac] Report domains using abnormally high memory usage via enhanced privacy logging
Summary: [Mac] Report domains using abnormally high memory usage via enhanced privacy ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-23 13:11 PST by Chris Dumez
Modified: 2017-02-24 11:26 PST (History)
5 users (show)

See Also:

Attachments
Patch (5.91 KB, patch)
2017-02-23 13:22 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews115 for mac-elcapitan (1.69 MB, application/zip)
2017-02-23 16:42 PST, Build Bot 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-02-23 13:11:41 PST 
Report domains using abnormally high memory usage (> 2GB) via enhanced privacy logging on Mac.
Comment 1 Chris Dumez 2017-02-23 13:12:02 PST 
<rdar://problem/29964017>
Comment 2 Chris Dumez 2017-02-23 13:22:00 PST 
Created attachment 302567 [details]
Patch
Comment 3 Build Bot 2017-02-23 16:42:16 PST 
Comment on attachment 302567 [details]
Patch

Attachment 302567 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3181783

New failing tests:
fast/dom/timer-throttling-hidden-page-non-nested.html
Comment 4 Build Bot 2017-02-23 16:42:20 PST 
Created attachment 302607 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 5 Andreas Kling 2017-02-23 22:32:46 PST 
Comment on attachment 302567 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302567&action=review

r=me

> Source/WebCore/page/DiagnosticLoggingKeys.cpp:353
> +    return ASCIILiteral("DomainCausingJetsam");

This seems like a bit of a misnomer, since it's not actually causing jetsam.
DomainCausingHighMemoryUsage?
Comment 6 Chris Dumez 2017-02-24 07:18:40 PST 
(In reply to comment #5)
> Comment on attachment 302567 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=302567&action=review
> 
> r=me
> 
> > Source/WebCore/page/DiagnosticLoggingKeys.cpp:353
> > +    return ASCIILiteral("DomainCausingJetsam");
> 
> This seems like a bit of a misnomer, since it's not actually causing jetsam.
> DomainCausingHighMemoryUsage?

It is not up to me, this IS the key we got assigned.
Comment 7 Chris Dumez 2017-02-24 07:21:00 PST 
(In reply to comment #6)
> (In reply to comment #5)
> > Comment on attachment 302567 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=302567&action=review
> > 
> > r=me
> > 
> > > Source/WebCore/page/DiagnosticLoggingKeys.cpp:353
> > > +    return ASCIILiteral("DomainCausingJetsam");
> > 
> > This seems like a bit of a misnomer, since it's not actually causing jetsam.
> > DomainCausingHighMemoryUsage?
> 
> It is not up to me, this IS the key we got assigned.

See radar for assigned key.
Comment 8 Chris Dumez 2017-02-24 11:26:10 PST 
Comment on attachment 302567 [details]
Patch

Clearing flags on attachment: 302567

Committed r212961: <http://trac.webkit.org/changeset/212961>
Comment 9 Chris Dumez 2017-02-24 11:26:18 PST 
All reviewed patches have been landed.  Closing bug.