RESOLVED FIXED168786
Ensure that the end of the last invalidation point does not extend beyond the end of the buffer. 
https://bugs.webkit.org/show_bug.cgi?id=168786
Summary Ensure that the end of the last invalidation point does not extend beyond the...
Mark Lam
Reported 2017-02-23 10:46:45 PST
In practice, we will always have multiple instructions after invalidation points, and have enough room in the JIT buffer for the invalidation point to work with. However, as a precaution, we can guarantee that there's enough room by always emitting a label just before we link the buffer. The label will emit nop padding if needed.
Attachments
proposed patch. (1.74 KB, patch)
2017-02-23 10:50 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews116 for mac-elcapitan (1.67 MB, application/zip)
2017-02-23 11:44 PST, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2017-02-23 10:50:26 PST
Created attachment 302533 [details] proposed patch.
Build Bot
Comment 2 2017-02-23 11:44:24 PST
Comment on attachment 302533 [details] proposed patch. Attachment 302533 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3179795 New failing tests: fast/dom/timer-throttling-hidden-page-non-nested.html
Build Bot
Comment 3 2017-02-23 11:44:28 PST
Created attachment 302547 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6
WebKit Commit Bot
Comment 4 2017-02-23 11:44:47 PST
Comment on attachment 302533 [details] proposed patch. Clearing flags on attachment: 302533 Committed r212908: <http://trac.webkit.org/changeset/212908>
WebKit Commit Bot
Comment 5 2017-02-23 11:44:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.