Bug 168785 - Add delegate method to handle images with alternate data.
Summary: Add delegate method to handle images with alternate data.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yongjun Zhang
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-23 10:24 PST by Yongjun Zhang
Modified: 2017-02-28 13:30 PST (History)
7 users (show)

See Also:

Attachments
Patch. (18.84 KB, patch)
2017-02-23 10:51 PST, Yongjun Zhang 		no flags Details | Formatted Diff | Diff
Fix mac build. (18.85 KB, patch)
2017-02-23 12:09 PST, Yongjun Zhang 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews117 for mac-elcapitan (1.69 MB, application/zip)
2017-02-23 15:47 PST, Build Bot 		no flags Details
Address Dan's comment, adding two delegate methods (one for async and another for sync) to get alternate data. (18.63 KB, patch)
2017-02-24 10:44 PST, Yongjun Zhang 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yongjun Zhang 2017-02-23 10:24:59 PST 
It would be nice to have new UIDelegate methods to handle images with alternate data.
Comment 1 Yongjun Zhang 2017-02-23 10:25:55 PST 
<rdar://problem/28776219>
Comment 2 Yongjun Zhang 2017-02-23 10:51:34 PST 
Created attachment 302534 [details]
Patch.
Comment 3 Yongjun Zhang 2017-02-23 12:09:59 PST 
Created attachment 302554 [details]
Fix mac build.
Comment 4 Build Bot 2017-02-23 15:47:19 PST 
Comment on attachment 302554 [details]
Fix mac build.

Attachment 302554 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3181500

New failing tests:
fast/dom/timer-throttling-hidden-page-non-nested.html
Comment 5 Build Bot 2017-02-23 15:47:22 PST 
Created attachment 302593 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 Yongjun Zhang 2017-02-24 10:44:47 PST 
Created attachment 302673 [details]
Address Dan's comment, adding two delegate methods (one for async and another for sync) to get alternate data.
Comment 7 Enrica Casucci 2017-02-28 13:00:30 PST 
Comment on attachment 302673 [details]
Address Dan's comment, adding two delegate methods (one for async and another for sync) to get alternate data.

Looks good to me!
Comment 8 WebKit Commit Bot 2017-02-28 13:30:50 PST 
Comment on attachment 302673 [details]
Address Dan's comment, adding two delegate methods (one for async and another for sync) to get alternate data.

Clearing flags on attachment: 302673

Committed r213170: <http://trac.webkit.org/changeset/213170>
Comment 9 WebKit Commit Bot 2017-02-28 13:30:54 PST 
All reviewed patches have been landed.  Closing bug.