Struts push lines down so the lineIndex = y / m_lineHeight is not correct anymore.
<rdar://problem/30676449>
Created attachment 302525 [details] Patch
Comment on attachment 302525 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302525&action=review > Source/WebCore/rendering/SimpleLineLayoutResolver.cpp:147 > + if (!m_layout.hasLineStruts()) > + return lineIndexCandidate; Could we factor the struts case to a function so that the common case stays clean? Something like if (m_layout.hasLineStruts()) return adjustLineIndexForStruts(lineIndexCandidate,...); return lineIndexCandidate;
Created attachment 302530 [details] Patch
The commit-queue encountered the following flaky tests while processing attachment 302530 [details]: editing/spelling/spellcheck-async.html bug 160571 (authors: g.czajkowski@samsung.com and mark.lam@apple.com) The commit-queue is continuing to process your patch.
The commit-queue encountered the following flaky tests while processing attachment 302530 [details]: The commit-queue is continuing to process your patch.
Comment on attachment 302530 [details] Patch Clearing flags on attachment: 302530 Committed r212912: <http://trac.webkit.org/changeset/212912>
All reviewed patches have been landed. Closing bug.