Bug 168782 - [WebRTC][Mac][WebKit2] WebRTC requires media capture
Summary: [WebRTC][Mac][WebKit2] WebRTC requires media capture
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-23 08:48 PST by Eric Carlson
Modified: 2017-02-23 18:39 PST (History)
5 users (show)

See Also:

Attachments
Proposed patch. (1.85 KB, patch)
2017-02-23 08:54 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews117 for mac-elcapitan (1.68 MB, application/zip)
2017-02-23 10:08 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.01 MB, application/zip)
2017-02-23 10:09 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews103 for mac-elcapitan (880.55 KB, application/zip)
2017-02-23 10:38 PST, Build Bot 		no flags Details
Patch for landing. (2.09 KB, patch)
2017-02-23 11:54 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2017-02-23 08:48:27 PST 
WebRTC requires camera and microphone access, so always extend the web process sandbox to allow microphone access if WebRTC is enabled.
Comment 1 Radar WebKit Bug Importer 2017-02-23 08:49:12 PST 
<rdar://problem/30675242>
Comment 2 Eric Carlson 2017-02-23 08:54:09 PST 
Created attachment 302516 [details]
Proposed patch.
Comment 3 youenn fablet 2017-02-23 09:21:22 PST 
Comment on attachment 302516 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=302516&action=review

> Source/WebKit2/UIProcess/Cocoa/WebProcessPoolCocoa.mm:255
> +        webRTCEnabled = [defaults boolForKey:@"ExperimentalPeerConnectionEnabled"];

I am wondering whether we should add a comment here explaining why we are also checking webRTCEnabled here.
Comment 4 Build Bot 2017-02-23 10:08:16 PST 
Comment on attachment 302516 [details]
Proposed patch.

Attachment 302516 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3179330

New failing tests:
media/modern-media-controls/volume-down-support/volume-down-support.html
Comment 5 Build Bot 2017-02-23 10:08:18 PST 
Created attachment 302527 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 Build Bot 2017-02-23 10:09:02 PST 
Comment on attachment 302516 [details]
Proposed patch.

Attachment 302516 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3179346

New failing tests:
media/modern-media-controls/volume-down-support/volume-down-support.html
Comment 7 Build Bot 2017-02-23 10:09:05 PST 
Created attachment 302528 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 8 Build Bot 2017-02-23 10:38:40 PST 
Comment on attachment 302516 [details]
Proposed patch.

Attachment 302516 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3179487

New failing tests:
editing/spelling/spellcheck-async.html
Comment 9 Build Bot 2017-02-23 10:38:43 PST 
Created attachment 302531 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 10 Eric Carlson 2017-02-23 11:54:22 PST 
Created attachment 302549 [details]
Patch for landing.
Comment 11 WebKit Commit Bot 2017-02-23 12:41:34 PST 
Comment on attachment 302549 [details]
Patch for landing.

Clearing flags on attachment: 302549

Committed r212915: <http://trac.webkit.org/changeset/212915>