RESOLVED FIXED 168782
[WebRTC][Mac][WebKit2] WebRTC requires media capture
https://bugs.webkit.org/show_bug.cgi?id=168782
Summary [WebRTC][Mac][WebKit2] WebRTC requires media capture
Eric Carlson
Reported 2017-02-23 08:48:27 PST
WebRTC requires camera and microphone access, so always extend the web process sandbox to allow microphone access if WebRTC is enabled.
Attachments
Proposed patch. (1.85 KB, patch)
2017-02-23 08:54 PST, Eric Carlson
no flags
Archive of layout-test-results from ews117 for mac-elcapitan (1.68 MB, application/zip)
2017-02-23 10:08 PST, Build Bot
no flags
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.01 MB, application/zip)
2017-02-23 10:09 PST, Build Bot
no flags
Archive of layout-test-results from ews103 for mac-elcapitan (880.55 KB, application/zip)
2017-02-23 10:38 PST, Build Bot
no flags
Patch for landing. (2.09 KB, patch)
2017-02-23 11:54 PST, Eric Carlson
no flags
Radar WebKit Bug Importer
Comment 1 2017-02-23 08:49:12 PST
Eric Carlson
Comment 2 2017-02-23 08:54:09 PST
Created attachment 302516 [details] Proposed patch.
youenn fablet
Comment 3 2017-02-23 09:21:22 PST
Comment on attachment 302516 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=302516&action=review > Source/WebKit2/UIProcess/Cocoa/WebProcessPoolCocoa.mm:255 > + webRTCEnabled = [defaults boolForKey:@"ExperimentalPeerConnectionEnabled"]; I am wondering whether we should add a comment here explaining why we are also checking webRTCEnabled here.
Build Bot
Comment 4 2017-02-23 10:08:16 PST
Comment on attachment 302516 [details] Proposed patch. Attachment 302516 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3179330 New failing tests: media/modern-media-controls/volume-down-support/volume-down-support.html
Build Bot
Comment 5 2017-02-23 10:08:18 PST
Created attachment 302527 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 6 2017-02-23 10:09:02 PST
Comment on attachment 302516 [details] Proposed patch. Attachment 302516 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3179346 New failing tests: media/modern-media-controls/volume-down-support/volume-down-support.html
Build Bot
Comment 7 2017-02-23 10:09:05 PST
Created attachment 302528 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Build Bot
Comment 8 2017-02-23 10:38:40 PST
Comment on attachment 302516 [details] Proposed patch. Attachment 302516 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3179487 New failing tests: editing/spelling/spellcheck-async.html
Build Bot
Comment 9 2017-02-23 10:38:43 PST
Created attachment 302531 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Eric Carlson
Comment 10 2017-02-23 11:54:22 PST
Created attachment 302549 [details] Patch for landing.
WebKit Commit Bot
Comment 11 2017-02-23 12:41:34 PST
Comment on attachment 302549 [details] Patch for landing. Clearing flags on attachment: 302549 Committed r212915: <http://trac.webkit.org/changeset/212915>
Note You need to log in before you can comment on or make changes to this bug.