Bug 168778 – [WebRTC] Outgoing video quality is poor

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

Resolution might decrease and latency is progressively adding up

[Radar WebKit Bug Importer]

<rdar://problem/30674673>

[youenn fablet]

Created attachment 302562 [details]
Patch

[Eric Carlson]

Comment on attachment 302562 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302562&action=review

> Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.h:59
> +    int64_t TimeUntilNextProcess() final { return 100000000; }

Nit: it would be nice to have a comment here explaining this magic number.

[youenn fablet]

Created attachment 302575 [details]
Patch for landing

[youenn fablet]

Thanks for the review.

(In reply to comment #3)
> Comment on attachment 302562 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=302562&action=review
> 
> > Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.h:59
> > +    int64_t TimeUntilNextProcess() final { return 100000000; }
> 
> Nit: it would be nice to have a comment here explaining this magic number.

Done

[WebKit Commit Bot]

Comment on attachment 302575 [details]
Patch for landing

Clearing flags on attachment: 302575

Committed r212931: <http://trac.webkit.org/changeset/212931>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.