Bug 168759 – Improve error message when the WPT server fails to start

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Carlos Alberto Lopez Perez]

If the WPT server fails to start, no useful message is printed that help the user to debug the problem.

[Carlos Alberto Lopez Perez]

Created attachment 302478 [details]
Patch

[Carlos Alberto Lopez Perez]

Created attachment 302482 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 302482 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302482&action=review

> Tools/Scripts/webkitpy/common/system/executive_mock.py:45
> +        self._running = False

boolean attribute like this should have verb at the beginning.
e.g. _is_running. See https://webkit.org/code-style-guidelines/#names-bool

> Tools/Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:166
> +            error_log = "WPT Server process exited prematurely with status code %s\n" % self._process.returncode
> +            error_log += "The cmdline for running the WPT server was: %s\n" % self._start_cmd
> +            error_log += "The working dir was: %s\n" % self._doc_root_path

Instead of += each, why don't we just use + instead?
Better yet, we can just use """.

[Build Bot]

Comment on attachment 302482 [details]
Patch

Attachment 302482 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3176520

New failing tests:
fast/dom/timer-throttling-hidden-page.html

[Build Bot]

Created attachment 302487 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Carlos Alberto Lopez Perez]

(In reply to comment #3)
> > Tools/Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:166
> > +            error_log = "WPT Server process exited prematurely with status code %s\n" % self._process.returncode
> > +            error_log += "The cmdline for running the WPT server was: %s\n" % self._start_cmd
> > +            error_log += "The working dir was: %s\n" % self._doc_root_path
> 
> Instead of += each, why don't we just use + instead?
> Better yet, we can just use """.

Using """ for a multi-line text block will cause the text to have extra leading white spaces added. Unless you align the text-block to the far left, but this looks ugly (IMHO) when defined on a code block that is indented.

I will use +.

Thanks for the review.

[Carlos Alberto Lopez Perez]

Committed r212905: <http://trac.webkit.org/changeset/212905>