Bug 168756 – [MediaStream iOS] Allow web process sandbox to be extended for media capture

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

As on macOS, access to audio & video capture devices from the WebProcess require sandbox extensions. As we do on macOS, generate extensions on dynamically when access is required instead of changing the sandbox permanently.

[Eric Carlson]

Created attachment 302470 [details]
Proposed patch.

[Radar WebKit Bug Importer]

<rdar://problem/30665364>

[Build Bot]

Comment on attachment 302470 [details]
Proposed patch.

Attachment 302470 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3175927

New failing tests:
fast/dom/timer-throttling-hidden-page-non-nested.html

[Build Bot]

Created attachment 302477 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Eric Carlson]

(In reply to comment #3)
> Comment on attachment 302470 [details]
> Proposed patch.
> 
> Attachment 302470 [details] did not pass mac-debug-ews (mac):
> Output: http://webkit-queues.webkit.org/results/3175927
> 
> New failing tests:
> fast/dom/timer-throttling-hidden-page-non-nested.html

This failure is not related, the patch only changes the iOS sandbox.

[Brent Fulgham]

Comment on attachment 302470 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=302470&action=review

r=me

> Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:110
> +(with-filter (extension "com.apple.webkit.camera")

Nit: I don't think you need "with-filter" on iOS, since all support versions of iOS will have this declared in the default sandbox "language".

[WebKit Commit Bot]

Comment on attachment 302470 [details]
Proposed patch.

Clearing flags on attachment: 302470

Committed r212883: <http://trac.webkit.org/changeset/212883>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.