Bug 168754 – Remove the demand executable allocator

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Keith Miller]

Remove the demand executable allocator

[Keith Miller]

Created attachment 302459 [details]
Patch

[WebKit Commit Bot]

Attachment 302459 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/jit/ExecutableAllocator.cpp:63:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/jit/ExecutableAllocator.cpp:63:  target_task is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/jit/ExecutableAllocator.cpp:64:  Declaration has space between type name and * in mach_vm_address_t *target_address  [whitespace/declaration] [3]
ERROR: Source/JavaScriptCore/jit/ExecutableAllocator.cpp:64:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/jit/ExecutableAllocator.cpp:65:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/jit/ExecutableAllocator.cpp:66:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/jit/ExecutableAllocator.cpp:67:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/jit/ExecutableAllocator.cpp:68:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/jit/ExecutableAllocator.cpp:68:  src_task is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/jit/ExecutableAllocator.cpp:69:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/jit/ExecutableAllocator.cpp:69:  src_address is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/jit/ExecutableAllocator.cpp:70:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/jit/ExecutableAllocator.cpp:71:  Declaration has space between type name and * in vm_prot_t *cur_protection  [whitespace/declaration] [3]
ERROR: Source/JavaScriptCore/jit/ExecutableAllocator.cpp:71:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/jit/ExecutableAllocator.cpp:72:  Declaration has space between type name and * in vm_prot_t *max_protection  [whitespace/declaration] [3]
ERROR: Source/JavaScriptCore/jit/ExecutableAllocator.cpp:72:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/jit/ExecutableAllocator.cpp:73:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/jit/ExecutableAllocator.cpp:74:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 18 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Saam Barati]

Comment on attachment 302459 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302459&action=review

> Source/JavaScriptCore/jit/ExecutableAllocator.cpp:2
> + * Copyright (C) 2008-2009, 2015 Apple Inc. All rights reserved.

should be 2017

[Keith Miller]

Created attachment 302461 [details]
benchmark results

Benchmark results show a 15-20% regression on crypto-md5 on 32-bit MBP but I couldn't find any reason why such a regression should occur. I'm not sure that one 32-bit benchmark is worth the code debt.

[Keith Miller]

Committed r212867: <http://trac.webkit.org/changeset/212867>

[Csaba Osztrogonác]

(In reply to comment #5)
> Committed r212867: <http://trac.webkit.org/changeset/212867>

It broke the cloop build.

[Csaba Osztrogonác]

*** Bug 154749 has been marked as a duplicate of this bug. ***

[Keith Miller]

(In reply to comment #6)
> (In reply to comment #5)
> > Committed r212867: <http://trac.webkit.org/changeset/212867>
> 
> It broke the cloop build.

Fixing.

[Keith Miller]

cloop should, hopefully, be fixed in: http://trac.webkit.org/changeset/212900