Bug 168752 - Web Inspector: Add "goto arrow" to DOMNodeTreeElements in the Debugger tab
Summary: Web Inspector: Add "goto arrow" to DOMNodeTreeElements in the Debugger tab
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords:
Depends on: 168101
Blocks:
  Show dependency tree / graph
 
Reported: 2017-02-22 16:00 PST by Matt Baker
Modified: 2017-03-11 21:02 PST (History)
2 users (show)

See Also:

Attachments
[Image] DOM node tree element UI (94.54 KB, image/png)
2017-02-22 16:00 PST, Matt Baker 		no flags Details
[Image] "Reveal in DOM tree" (132.82 KB, image/png)
2017-03-11 14:26 PST, Matt Baker 		no flags Details
Patch (5.21 KB, patch)
2017-03-11 14:35 PST, Matt Baker 		no flags Details | Formatted Diff | Diff
Patch for landing (5.24 KB, patch)
2017-03-11 20:21 PST, Matt Baker 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2017-02-22 16:00:16 PST 
Created attachment 302457 [details]
[Image] DOM node tree element UI

See screenshot.
Comment 1 Matt Baker 2017-03-11 14:26:43 PST 
Created attachment 304177 [details]
[Image] "Reveal in DOM tree"
Comment 2 Matt Baker 2017-03-11 14:35:24 PST 
Created attachment 304178 [details]
Patch
Comment 3 Devin Rousso 2017-03-11 17:12:31 PST 
Comment on attachment 304178 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304178&action=review

> Source/WebInspectorUI/UserInterface/Views/DOMNodeTreeElement.js:54
> +        contextMenu.appendSeparator();
> +        contextMenu.appendItem(WebInspector.UIString("Reveal in DOM Tree"), () => {

NIT: I think there should be a newline between these lines.
Comment 4 Matt Baker 2017-03-11 20:21:03 PST 
Created attachment 304182 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2017-03-11 21:02:29 PST 
Comment on attachment 304182 [details]
Patch for landing

Clearing flags on attachment: 304182

Committed r213765: <http://trac.webkit.org/changeset/213765>
Comment 6 WebKit Commit Bot 2017-03-11 21:02:33 PST 
All reviewed patches have been landed.  Closing bug.