Bug 168748 - [WebRTC] Add support for libwebrtc TCP incoming connections
Summary: [WebRTC] Add support for libwebrtc TCP incoming connections
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-22 15:23 PST by youenn fablet
Modified: 2017-02-27 17:12 PST (History)
3 users (show)

See Also:

Attachments
Patch (25.69 KB, patch)
2017-02-27 10:48 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (26.17 KB, patch)
2017-02-27 11:13 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (26.08 KB, patch)
2017-02-27 12:32 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-02-22 15:23:38 PST 
[WebRTC] Add support for libwebrtc TCP incoming connections
Comment 1 youenn fablet 2017-02-27 10:48:56 PST 
Created attachment 302849 [details]
Patch
Comment 2 WebKit Commit Bot 2017-02-27 10:50:32 PST 
Attachment 302849 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/webrtc/LibWebRTCSocketClient.h:52:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebKit2/NetworkProcess/webrtc/LibWebRTCSocketClient.h:70:  The parameter name "socket" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/WebProcess/Network/webrtc/LibWebRTCSocket.h:51:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 3 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alex Christensen 2017-02-27 10:54:33 PST 
Comment on attachment 302849 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302849&action=review

> Source/WebKit2/NetworkProcess/webrtc/LibWebRTCSocketClient.cpp:56
> +    if (type == Type::ServerConnectionTCP)

switch(type)

> Source/WebKit2/WebProcess/Network/webrtc/WebRTCSocket.h:58
> +    void signalNewConnection(uint64_t newSocketIdentifiert, const WebKit::RTCNetwork::SocketAddress&);

Identifier
Comment 4 youenn fablet 2017-02-27 11:13:41 PST 
Created attachment 302854 [details]
Patch for landing
Comment 5 youenn fablet 2017-02-27 11:13:56 PST 
Thanks for the review.

(In reply to comment #3)
> Comment on attachment 302849 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=302849&action=review
> 
> > Source/WebKit2/NetworkProcess/webrtc/LibWebRTCSocketClient.cpp:56
> > +    if (type == Type::ServerConnectionTCP)

Done

> switch(type)
> 
> > Source/WebKit2/WebProcess/Network/webrtc/WebRTCSocket.h:58
> > +    void signalNewConnection(uint64_t newSocketIdentifiert, const WebKit::RTCNetwork::SocketAddress&);
> 
> Identifier

Done
Comment 6 youenn fablet 2017-02-27 12:32:19 PST 
Created attachment 302864 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2017-02-27 17:12:31 PST 
Comment on attachment 302864 [details]
Patch for landing

Clearing flags on attachment: 302864

Committed r213104: <http://trac.webkit.org/changeset/213104>
Comment 8 WebKit Commit Bot 2017-02-27 17:12:35 PST 
All reviewed patches have been landed.  Closing bug.