Bug 168747 - [Modern Media Controls] Can't set the volume slider with macOS inline controls
Summary: [Modern Media Controls] Can't set the volume slider with macOS inline controls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-22 14:56 PST by Antoine Quint
Modified: 2017-02-22 16:20 PST (History)
2 users (show)

See Also:

Attachments
Patch (6.41 KB, patch)
2017-02-22 15:50 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch for landing (6.41 KB, patch)
2017-02-22 16:03 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2017-02-22 14:56:35 PST 
It's impossible to set the volume using the volume slider with macOS inline controls.
Comment 1 Antoine Quint 2017-02-22 14:56:59 PST 
<rdar://problem/30605528>
Comment 2 Antoine Quint 2017-02-22 15:50:14 PST 
Created attachment 302454 [details]
Patch
Comment 3 Dean Jackson 2017-02-22 15:53:52 PST 
Comment on attachment 302454 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302454&action=review

> Source/WebCore/ChangeLog:9
> +        Only call super only for events we haven't registered in the context of this class

only only

> Source/WebCore/ChangeLog:10
> +        specifically. Otherwise we'd invalidate the volume container visibility for a

specifically in the context of this class.
Comment 4 Antoine Quint 2017-02-22 16:03:28 PST 
Created attachment 302458 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2017-02-22 16:20:51 PST 
Comment on attachment 302458 [details]
Patch for landing

Clearing flags on attachment: 302458

Committed r212861: <http://trac.webkit.org/changeset/212861>
Comment 6 WebKit Commit Bot 2017-02-22 16:20:55 PST 
All reviewed patches have been landed.  Closing bug.