WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
168747
[Modern Media Controls] Can't set the volume slider with macOS inline controls
https://bugs.webkit.org/show_bug.cgi?id=168747
Summary
[Modern Media Controls] Can't set the volume slider with macOS inline controls
Antoine Quint
Reported
2017-02-22 14:56:35 PST
It's impossible to set the volume using the volume slider with macOS inline controls.
Attachments
Patch
(6.41 KB, patch)
2017-02-22 15:50 PST
,
Antoine Quint
no flags
Details
Formatted Diff
Diff
Patch for landing
(6.41 KB, patch)
2017-02-22 16:03 PST
,
Antoine Quint
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Antoine Quint
Comment 1
2017-02-22 14:56:59 PST
<
rdar://problem/30605528
>
Antoine Quint
Comment 2
2017-02-22 15:50:14 PST
Created
attachment 302454
[details]
Patch
Dean Jackson
Comment 3
2017-02-22 15:53:52 PST
Comment on
attachment 302454
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=302454&action=review
> Source/WebCore/ChangeLog:9 > + Only call super only for events we haven't registered in the context of this class
only only
> Source/WebCore/ChangeLog:10 > + specifically. Otherwise we'd invalidate the volume container visibility for a
specifically in the context of this class.
Antoine Quint
Comment 4
2017-02-22 16:03:28 PST
Created
attachment 302458
[details]
Patch for landing
WebKit Commit Bot
Comment 5
2017-02-22 16:20:51 PST
Comment on
attachment 302458
[details]
Patch for landing Clearing flags on attachment: 302458 Committed
r212861
: <
http://trac.webkit.org/changeset/212861
>
WebKit Commit Bot
Comment 6
2017-02-22 16:20:55 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug