Bug 168746 – Web Inspector: RTL: Elements tab Styles sidebar label/arrows need adjustment

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Matt Baker]

Created attachment 302448 [details]
[Image] Styles arrow glyph spacing

This was fixed for navigation sidebars, but details sidebars are broken.

[Devin Rousso]

Created attachment 302595 [details]
Patch

[Devin Rousso]

Created attachment 302596 [details]
[Image] After Patch is applied

[Blaze Burg]

Comment on attachment 302595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302595&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/ScopeRadioButtonNavigationItem.css:29
> +    --scope-radio-button-navigation-item-select-start: 0;

NIt: should say 'offset-start' if using CSS property 'left' in LTR.

[Devin Rousso]

Created attachment 302742 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 302742 [details]
Patch

Rejecting attachment 302742 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 302742, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
: Uncaught Exception: Unknown angle units "undefined"
The copy of the patch that failed is found in:
   /Volumes/Data/EWS/WebKit/.git/rebase-apply/patch

When you have resolved this problem, run "git rebase --continue".
If you prefer to skip this patch, run "git rebase --skip" instead.
To check out the original branch and stop rebasing, run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at /Volumes/Data/EWS/WebKit/Tools/Scripts/webkitdirs.pm line 2607.

Full output: http://webkit-queues.webkit.org/results/3189993

[Devin Rousso]

Created attachment 302749 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 302749 [details]
Patch

Clearing flags on attachment: 302749

Committed r213001: <http://trac.webkit.org/changeset/213001>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.