Created attachment 302443 [details] [Image] Screenshot of Issue .
Created attachment 302452 [details] Patch
Please include screenshots of the UI in RTL and LTR with patch applied.
Created attachment 302523 [details] [Image] After Patch is applied
Comment on attachment 302452 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302452&action=review r=me. Impressive work! > Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css:105 > + padding-right: calc(var(--sublist-margin-start) + var(--sublist-padding-start) + var(--sublist-border-width-start)); Very nice. > Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css:117 > + border: 0 solid hsla(0, 0%, 83%, 0.5); Do we have an existing color variable for this? Not sure what the AppKit equivalent is... > Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css:133 > + border-color: hsl(0, 0%, 83%); Ditto. > Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css:145 > + padding: 0 var(--item-padding-start) 0 var(--item-padding-end); I prefer explicit padding-side properties because it's easier to match up left + start and right + end. But I guess this is ok. > Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css:204 > + margin-right: calc(-1 * var(--sublist-margin-start) - var(--sublist-border-width-start)); Clever.
Comment on attachment 302452 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302452&action=review >> Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css:117 >> + border: 0 solid hsla(0, 0%, 83%, 0.5); > > Do we have an existing color variable for this? Not sure what the AppKit equivalent is... We don't, and this is also the only place that it's used. >> Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css:133 >> + border-color: hsl(0, 0%, 83%); > > Ditto. We do, but it doesn't really apply for this case: --selected-background-color-unfocused in Variables.css
Comment on attachment 302452 [details] Patch Clearing flags on attachment: 302452 Committed r212913: <http://trac.webkit.org/changeset/212913>
All reviewed patches have been landed. Closing bug.