Bug 16874 - [Gtk] Missing symbols when compiling with --enable-svg-filters
Summary: [Gtk] Missing symbols when compiling with --enable-svg-filters
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on:
Reported: 2008-01-14 11:05 PST by Pierre-Luc Beaudoin
Modified: 2008-01-14 21:41 PST (History)
0 users

See Also:

Stubs (2.17 KB, patch)
2008-01-14 11:07 PST, Pierre-Luc Beaudoin
mrowe: review-
Details | Formatted Diff | Diff
No tab and a ChangeLog (2.96 KB, patch)
2008-01-14 19:27 PST, Pierre-Luc Beaudoin
alp: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre-Luc Beaudoin 2008-01-14 11:05:54 PST
WebCore::SVGResourceFilter::applyFilter(WebCore::GraphicsContext*&, WebCore::FloatRect const&)
WebCore::SVGResourceFilter::prepareFilter(WebCore::GraphicsContext*&, WebCore::FloatRect const&)
implementation are missing
Comment 1 Pierre-Luc Beaudoin 2008-01-14 11:07:07 PST
Created attachment 18443 [details]

Empty implementations to fix build.
Comment 2 Mark Rowe (bdash) 2008-01-14 18:13:36 PST
Comment on attachment 18443 [details]

A tab has snuck into your change, and it needs a changelog. Can you fix those two things and resubmit please?
Comment 3 Pierre-Luc Beaudoin 2008-01-14 19:27:59 PST
Created attachment 18451 [details]
No tab and a ChangeLog

How did a tab get there!  It seems to be a bug in Gedit... only on that line, it insists on inserting a tab.
I also though the change were so trivial that it didn't require a ChangeLog.  Now I know all changes need one.
Comment 4 Alp Toker 2008-01-14 21:41:57 PST
Landed in r29486.