Bug 168737 – AutoInstaller should not skip the install step if the package is downloaded but not installed

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Carlos Alberto Lopez Perez]

When installing a python library for the tests via AutoInstaller, there is an optional argument "should_refresh" that can be defined to instruct the installer to always re-download and re-install such package.


The issue is that "should_refresh" only checks if the source tarball is downloaded, but it ignores the fact that it can be already installed or not

This can happen if the user manually cleans the installation folder for the auto-installed python libraries or if the installation of the library failed previously for any reason.

So... what ends happening is that the module never gets installed.

This has bitten me, I was cleaning the automatically installed wpt-tools library at LayoutTests/imported/w3c/web-platform-tests/tools, but wiping the tools sub-directory never caused this library to be installed again.

The check to decide if the installation step should be skipped, it was only checking for the existence of the file defined at LayoutTests/imported/w3c/web-platform-tests/.tools.url rather than checking also for the target directory to exist.

[Carlos Alberto Lopez Perez]

Created attachment 302426 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 302426 [details]
Patch

Looks sane.

[WebKit Commit Bot]

Comment on attachment 302426 [details]
Patch

Clearing flags on attachment: 302426

Committed r212852: <http://trac.webkit.org/changeset/212852>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.