Bug 168732 – Move instance members from WebSelectionRect.h to implementation file

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Aakash Jain]

There are few symbols in WebSelectionRect interface in WebKit/ios/WebCoreSupport/WebSelectionRect.h and are not exported. We should export these symbols so that the headers matches with the library.

[Aakash Jain]

Created attachment 302413 [details]
Proposed patch

[Tim Horton]

If they're not exported, does that mean that nobody is using them, so maybe they shouldn't be in the header?

[Aakash Jain]

Yes, I believe that's another option. I'm not sure which option is better.

[Alexey Proskuryakov]

This seems like an issue for many classes. Even for those that hide instance variables in _private, we still have to export _private.

I wonder if there is a better way to explain to the toolchain that private instance variables don't need symbols exported for them.

[Tim Horton]

(In reply to comment #4)
> This seems like an issue for many classes. Even for those that hide instance
> variables in _private, we still have to export _private.
> 
> I wonder if there is a better way to explain to the toolchain that private
> instance variables don't need symbols exported for them.

Can we not move instance members to the implementation for iOS-only files (can't do it for things built on Mac because of the modern runtime), for some reason? Then, do we have to export anything?

[Aakash Jain]

Created attachment 302427 [details]
Updated patch

[Aakash Jain]

(In reply to comment #5)
> Can we not move instance members to the implementation for iOS-only files
> (can't do it for things built on Mac because of the modern runtime), for
> some reason? Then, do we have to export anything?

Yes, I believe that would be clean approach. Patch updated.

[Tim Horton]

Comment on attachment 302427 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302427&action=review

> Source/WebKit/ios/WebCoreSupport/WebSelectionRect.h:32
>  @interface WebSelectionRect : NSObject <NSCopying> {

All of the comments from bug 168705 apply here too!

[Aakash Jain]

Created attachment 302437 [details]
Updated patch

remove extra {} and added ivars to @implementation.

[WebKit Commit Bot]

Comment on attachment 302437 [details]
Updated patch

Clearing flags on attachment: 302437

Committed r212856: <http://trac.webkit.org/changeset/212856>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.