Bug 168729 - Simple line layout: ensureLineBoxes for paginated content.
Summary: Simple line layout: ensureLineBoxes for paginated content.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-22 09:34 PST by zalan
Modified: 2017-02-22 11:34 PST (History)
11 users (show)

See Also:

Attachments
Patch (9.11 KB, patch)
2017-02-22 10:13 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (9.95 KB, patch)
2017-02-22 11:06 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-02-22 09:34:08 PST 
When we need to switch over from simple line runs to inline tree for paginated content.
Comment 1 Radar WebKit Bug Importer 2017-02-22 09:34:50 PST 
<rdar://problem/30654400>
Comment 2 zalan 2017-02-22 10:13:56 PST 
Created attachment 302408 [details]
Patch
Comment 3 Antti Koivisto 2017-02-22 10:38:20 PST 
Comment on attachment 302408 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302408&action=review

> Source/WebCore/rendering/RenderView.cpp:1240
> +    m_layoutState->m_pageLogicalHeight = LayoutUnit(1);

Can we do something less magical with this? At least a comment would be good.
Comment 4 zalan 2017-02-22 11:06:46 PST 
Created attachment 302417 [details]
Patch
Comment 5 WebKit Commit Bot 2017-02-22 11:34:48 PST 
Comment on attachment 302417 [details]
Patch

Clearing flags on attachment: 302417

Committed r212843: <http://trac.webkit.org/changeset/212843>
Comment 6 WebKit Commit Bot 2017-02-22 11:34:53 PST 
All reviewed patches have been landed.  Closing bug.