Bug 168717 - [GStreamer][EME] Fix issue with allowed systems extraction
Summary: [GStreamer][EME] Fix issue with allowed systems extraction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xabier Rodríguez Calvar
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-22 04:28 PST by Xabier Rodríguez Calvar
Modified: 2017-02-22 08:59 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.43 KB, patch)
2017-02-22 04:30 PST, Xabier Rodríguez Calvar
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xabier Rodríguez Calvar 2017-02-22 04:28:28 PST
[GStreamer][EME] Fix issue with allowed systems extraction
Comment 1 Xabier Rodríguez Calvar 2017-02-22 04:30:24 PST
Created attachment 302386 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-02-22 04:41:23 PST
Comment on attachment 302386 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302386&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:271
>      unsigned i;
> -    for (i = 0; !streamEncryptionAllowedSystems[i]; ++i)
> +    for (i = 0; streamEncryptionAllowedSystems[i]; ++i)

for (unsigned i = 0
Comment 3 Xabier Rodríguez Calvar 2017-02-22 08:38:56 PST
Comment on attachment 302386 [details]
Patch

(In reply to comment #2)
> Comment on attachment 302386 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=302386&action=review
> 
> > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:271
> >      unsigned i;
> > -    for (i = 0; !streamEncryptionAllowedSystems[i]; ++i)
> > +    for (i = 0; streamEncryptionAllowedSystems[i]; ++i)
> 
> for (unsigned i = 0

I can't, i is used later.
Comment 4 WebKit Commit Bot 2017-02-22 08:56:31 PST
Comment on attachment 302386 [details]
Patch

Clearing flags on attachment: 302386

Committed r212830: <http://trac.webkit.org/changeset/212830>
Comment 5 WebKit Commit Bot 2017-02-22 08:56:35 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Carlos Garcia Campos 2017-02-22 08:57:15 PST
(In reply to comment #3)
> Comment on attachment 302386 [details]
> Patch
> 
> (In reply to comment #2)
> > Comment on attachment 302386 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=302386&action=review
> > 
> > > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:271
> > >      unsigned i;
> > > -    for (i = 0; !streamEncryptionAllowedSystems[i]; ++i)
> > > +    for (i = 0; streamEncryptionAllowedSystems[i]; ++i)
> > 
> > for (unsigned i = 0
> 
> I can't, i is used later.

It's used later in a similar for loop that should do the same.
Comment 7 Xabier Rodríguez Calvar 2017-02-22 08:59:55 PST
(In reply to comment #6)
> It's used later in a similar for loop that should do the same.

Roger for the next time.