Bug 168700 - Do not aggressively throttle DOM timers until they've reached their max nesting level
Summary: Do not aggressively throttle DOM timers until they've reached their max nesti...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 118301
  Show dependency tree / graph
 
Reported: 2017-02-21 19:01 PST by Chris Dumez
Modified: 2017-02-22 12:46 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.03 KB, patch)
2017-02-21 19:03 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (11.44 KB, patch)
2017-02-22 09:21 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (964.68 KB, application/zip)
2017-02-22 10:23 PST, Build Bot 		no flags Details
Patch (12.25 KB, patch)
2017-02-22 10:26 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-02-21 19:01:41 PST 
Do not aggressively throttle DOM timers until they've reached their max nesting level.

This is what's causing Google Maps to use 100% CPU usage in background tabs for several minutes.
Comment 1 Chris Dumez 2017-02-21 19:02:03 PST 
<rdar://problem/29808005>
Comment 2 Chris Dumez 2017-02-21 19:03:55 PST 
Created attachment 302354 [details]
Patch
Comment 3 Simon Fraser (smfr) 2017-02-21 19:40:58 PST 
Comment on attachment 302354 [details]
Patch

Is there a way to test this?
Comment 4 Chris Dumez 2017-02-21 19:53:58 PST 
(In reply to comment #3)
> Comment on attachment 302354 [details]
> Patch
> 
> Is there a way to test this?

Maybe. I'll look into it tomorrow.
Comment 5 Chris Dumez 2017-02-22 09:21:48 PST 
Created attachment 302405 [details]
Patch
Comment 6 Build Bot 2017-02-22 10:23:26 PST 
Comment on attachment 302405 [details]
Patch

Attachment 302405 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3173399

New failing tests:
fast/dom/timer-throttling-hidden-page.html
Comment 7 Build Bot 2017-02-22 10:23:30 PST 
Created attachment 302409 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 8 Chris Dumez 2017-02-22 10:26:17 PST 
Created attachment 302411 [details]
Patch
Comment 9 WebKit Commit Bot 2017-02-22 12:46:17 PST 
Comment on attachment 302411 [details]
Patch

Clearing flags on attachment: 302411

Committed r212845: <http://trac.webkit.org/changeset/212845>
Comment 10 WebKit Commit Bot 2017-02-22 12:46:22 PST 
All reviewed patches have been landed.  Closing bug.