WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
168689
Export various NSString symbols from WebViewPrivate.h
https://bugs.webkit.org/show_bug.cgi?id=168689
Summary
Export various NSString symbols from WebViewPrivate.h
Aakash Jain
Reported
2017-02-21 16:05:03 PST
There are few symbols which are "extern NSString" in WebViewPrivate.h and are not exported. We should export these symbols so that the headers matches with the library.
Attachments
Proposed patch
(1.27 KB, patch)
2017-02-21 16:12 PST
,
Aakash Jain
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2
(953.81 KB, application/zip)
2017-02-21 17:28 PST
,
Build Bot
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
Aakash Jain
Comment 1
2017-02-21 16:12:00 PST
Created
attachment 302329
[details]
Proposed patch
Build Bot
Comment 2
2017-02-21 17:28:35 PST
Comment on
attachment 302329
[details]
Proposed patch
Attachment 302329
[details]
did not pass ios-sim-ews (ios-simulator-wk2): Output:
http://webkit-queues.webkit.org/results/3169115
New failing tests: http/tests/loading/resourceLoadStatistics/classify-as-non-prevalent-based-on-mixed-statistics.html
Build Bot
Comment 3
2017-02-21 17:28:38 PST
Created
attachment 302347
[details]
Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
WebKit Commit Bot
Comment 4
2017-02-21 18:41:17 PST
Comment on
attachment 302329
[details]
Proposed patch Clearing flags on attachment: 302329 Committed
r212792
: <
http://trac.webkit.org/changeset/212792
>
WebKit Commit Bot
Comment 5
2017-02-21 18:41:22 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug