RESOLVED FIXED 168688
No need for static attributes when creating a pixel format 
https://bugs.webkit.org/show_bug.cgi?id=168688
Summary No need for static attributes when creating a pixel format
Dean Jackson
Reported 2017-02-21 16:01:03 PST
GraphicsContext3DManager::updateHighPerformanceState() uses a static for some CGLPixelFormatAttributes. There isn't any point. Just create them each time.
Attachments
Patch (2.25 KB, patch)
2017-02-21 16:03 PST, Dean Jackson 		mmaxfield: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-02-21 16:01:26 PST
<rdar://problem/30642256>
Dean Jackson
Comment 2 2017-02-21 16:03:12 PST
Created attachment 302327 [details] Patch
Sam Weinig
Comment 3 2017-02-21 16:35:25 PST
Comment on attachment 302327 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302327&action=review > Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm:268 > + Vector<CGLPixelFormatAttribute> attributes; I think you can use initializer list syntax for this. Vector<CGLPixelFormatAttribute> attributes { kCGLPFAAccelerated, kCGLPFAColorSize, static_cast<CGLPixelFormatAttribute>(32), static_cast<CGLPixelFormatAttribute>(0) };
Dean Jackson
Comment 4 2017-02-21 17:24:48 PST
Committed r212783: <http://trac.webkit.org/changeset/212783>
Note You need to log in before you can comment on or make changes to this bug.