Bug 168680 - [Resource Timing] Media elements initiated loads should set the initiatorType to their element name (video/audio)
Summary: [Resource Timing] Media elements initiated loads should set the initiatorType...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-21 15:05 PST by Joseph Pecoraro
Modified: 2017-02-24 23:52 PST (History)
4 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (6.77 KB, patch)
2017-02-21 15:08 PST, Joseph Pecoraro 		joepeck: commit-queue-
Details | Formatted Diff | Diff
[PATCH] Proposed Fix (9.34 KB, patch)
2017-02-21 15:42 PST, Joseph Pecoraro 		youennf: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-02-21 15:05:46 PST 
[Resource Timing] Media elements initiated loads should set the initiatorType to their element name (video/audio)

Media loads should set the CachedResourceRequest with element initiator.
Comment 1 Joseph Pecoraro 2017-02-21 15:08:05 PST 
Created attachment 302318 [details]
[PATCH] Proposed Fix
Comment 2 Joseph Pecoraro 2017-02-21 15:22:24 PST 
Comment on attachment 302318 [details]
[PATCH] Proposed Fix

Oo, TestWebKitAPI. On it.
Comment 3 Joseph Pecoraro 2017-02-21 15:42:45 PST 
Created attachment 302322 [details]
[PATCH] Proposed Fix
Comment 4 youenn fablet 2017-02-24 08:07:23 PST 
Comment on attachment 302322 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=302322&action=review

> Source/WebCore/loader/MediaResourceLoader.cpp:81
> +    cacheRequest.setInitiator(*m_mediaElement.get());

I would remove the use of get(), since it looses RefPtr operator* assert.
Comment 5 Joseph Pecoraro 2017-02-24 23:52:18 PST 
<https://trac.webkit.org/changeset/212994>