Bug 168679 - Export various NSString symbols from WebUIDelegatePrivate.h
Summary: Export various NSString symbols from WebUIDelegatePrivate.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-21 14:59 PST by Aakash Jain
Modified: 2017-02-21 15:51 PST (History)
6 users (show)

See Also:

Attachments
Proposed patch (1.57 KB, patch)
2017-02-21 15:02 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2017-02-21 14:59:57 PST 
There are about 15 symbols which are "extern NSString" in WebUIDelegatePrivate.h. We should export these symbols so that the headers matches with the library.
Comment 1 Aakash Jain 2017-02-21 15:02:43 PST 
Created attachment 302317 [details]
Proposed patch
Comment 2 Joseph Pecoraro 2017-02-21 15:21:38 PST 
Comment on attachment 302317 [details]
Proposed patch

Looks like in source we have WebConsoleMessageContentBlockerMessageSource. Should we create an extern + exp entry for that as well?
Comment 3 Aakash Jain 2017-02-21 15:25:25 PST 
Possibly! I think that should be a separate patch.
Comment 4 WebKit Commit Bot 2017-02-21 15:51:28 PST 
Comment on attachment 302317 [details]
Proposed patch

Clearing flags on attachment: 302317

Committed r212774: <http://trac.webkit.org/changeset/212774>
Comment 5 WebKit Commit Bot 2017-02-21 15:51:33 PST 
All reviewed patches have been landed.  Closing bug.