Repatch's assembly dump assumes there's a CodeBlock present. WebAssembly doesn't have one. It crashes.
Created attachment 302304 [details]
Comment on attachment 302304 [details]
I think you should make it easier to say this, since we say it in multiple places. In fact, the usual dumping style for CodeBlock+CodeOrigin is:
dataLog(pointerDump(codeBlock), " ", codeOrigin)
I think that's what we want here as well. But maybe we can take it a step further and create a helper for it. The right way to go is something like:
Where FullCodeOrigin is a simple value class that holds a CodeBlock* and a CodeOrigin, and has a `void dump(PrintStream&) const` that prints them out.
Created attachment 302337 [details]
Add a helper class as Fil suggested, and use it in a bunch of places. This is nice.
Attachment 302337 [details] did not pass style-queue:
Total errors found: 1 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 302337 [details]
Created attachment 302339 [details]
Comment on attachment 302339 [details]
Clearing flags on attachment: 302339
Committed r212782: <http://trac.webkit.org/changeset/212782>
All reviewed patches have been landed. Closing bug.