Bug 168673 – Repatch assembly dump: allow having no CodeBlock

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[JF Bastien]

Repatch's assembly dump assumes there's a CodeBlock present. WebAssembly doesn't have one. It crashes.

[JF Bastien]

Created attachment 302304 [details]
patch

[Filip Pizlo]

Comment on attachment 302304 [details]
patch

I think you should make it easier to say this, since we say it in multiple places.  In fact, the usual dumping style for CodeBlock+CodeOrigin is:

dataLog(pointerDump(codeBlock), " ", codeOrigin)

I think that's what we want here as well.  But maybe we can take it a step further and create a helper for it.  The right way to go is something like:

dataLog(FullCodeOrigin(codeBock, codeOrigin))

Where FullCodeOrigin is a simple value class that holds a CodeBlock* and a CodeOrigin, and has a `void dump(PrintStream&) const` that prints them out.

[JF Bastien]

Created attachment 302337 [details]
patch

Add a helper class as Fil suggested, and use it in a bunch of places. This is nice.

[WebKit Commit Bot]

Attachment 302337 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/FullCodeOrigin.h:28:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[JF Bastien]

Comment on attachment 302337 [details]
patch

Style fix.

[JF Bastien]

Created attachment 302339 [details]
patch

Fix style.

[WebKit Commit Bot]

Comment on attachment 302339 [details]
patch

Clearing flags on attachment: 302339

Committed r212782: <http://trac.webkit.org/changeset/212782>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.