RESOLVED FIXED 168669
Using the touchbar, both align left and align justify send a beforeinput event with the 'formatJustifyLeft' inputType.
https://bugs.webkit.org/show_bug.cgi?id=168669
Summary Using the touchbar, both align left and align justify send a beforeinput even...
charleyroy
Reported 2017-02-21 12:40:18 PST
Using the Safari Tech Preview, whether I press Left Align in the touch bar or Justify Align, a beforeinput event is sent with the event type 'formatJustifyLeft'. Note that right align and center align do 'formatJustifyRight' and 'formatJustifyCenter' respectively. This is problematic as developers can't differentiate which alignment option was selected. Test bed: https://jsfiddle.net/L8qzozom/
Attachments
Patch (6.50 KB, patch)
2017-08-25 10:13 PDT, Wenson Hsieh
no flags
Radar WebKit Bug Importer
Comment 1 2017-02-21 14:01:12 PST
Wenson Hsieh
Comment 2 2017-02-21 14:50:42 PST
Currently, the input events spec only has "formatJustifyCenter", "formatJustifyRight", and "formatJustifyLeft" input types. As you pointed out, the spec needs a way of differentiating left-aligned justified alignment from left-aligned unjustified alignment. Perhaps we need input types for "formatAlignLeft", "formatAlignCenter" and "formatAlignRight"?
Wenson Hsieh
Comment 3 2017-08-24 18:02:37 PDT
I filed <https://github.com/w3c/input-events/issues/68> regarding how we can't distinguish between justifying and just aligning text. Would "formatAlign{Left|Center|Right}" and a separate "formatJustify" inputType be more appropriate here?
Wenson Hsieh
Comment 4 2017-08-25 09:15:21 PDT
From https://github.com/w3c/input-events/issues/68, Johannes proposed adding a new "formatJustifyFull" input type to capture the behavior of the rightmost "justify" button in the touch bar's rich text editing UI, so the alignment controls on the touch bar would emit (from left to right): "formatJustifyLeft", "formatJustifyCenter", "formatJustifyRight" and "formatJustifyFull". Does this sound reasonable?
Wenson Hsieh
Comment 5 2017-08-25 10:13:03 PDT
WebKit Commit Bot
Comment 6 2017-08-25 12:04:27 PDT
Comment on attachment 319087 [details] Patch Clearing flags on attachment: 319087 Committed r221199: <http://trac.webkit.org/changeset/221199>
WebKit Commit Bot
Comment 7 2017-08-25 12:04:28 PDT
All reviewed patches have been landed. Closing bug.
Lucas Forschler
Comment 8 2019-02-06 09:18:40 PST
Mass move bugs into the DOM component.
Note You need to log in before you can comment on or make changes to this bug.