Bug 168666 - [Win] When GraphicsLayerCA::m_uncommittedChanges is initialized with a non-zero value, nothing is painted.
Summary: [Win] When GraphicsLayerCA::m_uncommittedChanges is initialized with a non-ze...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-21 10:57 PST by Per Arne Vollan
Modified: 2020-06-01 13:15 PDT (History)
9 users (show)

See Also:

Attachments
Patch (2.25 KB, patch)
2017-02-22 03:52 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (841.03 KB, application/zip)
2017-02-22 05:10 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews100 for mac-elcapitan (992.28 KB, application/zip)
2017-02-22 05:47 PST, Build Bot 		no flags Details
Patch (2.25 KB, patch)
2017-02-24 02:13 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2017-02-21 10:57:01 PST 
This should be investigated and fixed, also see https://bugs.webkit.org/show_bug.cgi?id=64808.
Comment 1 Per Arne Vollan 2017-02-22 03:52:42 PST 
Created attachment 302384 [details]
Patch
Comment 2 Build Bot 2017-02-22 05:10:32 PST 
Comment on attachment 302384 [details]
Patch

Attachment 302384 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3172192

New failing tests:
scrollingcoordinator/ios/non-stable-viewport-scroll.html
Comment 3 Build Bot 2017-02-22 05:10:35 PST 
Created attachment 302389 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 4 Build Bot 2017-02-22 05:46:57 PST 
Comment on attachment 302384 [details]
Patch

Attachment 302384 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3172352

New failing tests:
editing/spelling/spellcheck-async.html
Comment 5 Build Bot 2017-02-22 05:47:00 PST 
Created attachment 302390 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 Per Arne Vollan 2017-02-24 02:13:04 PST 
Created attachment 302661 [details]
Patch
Comment 7 Per Arne Vollan 2017-02-24 02:15:21 PST 
(In reply to comment #6)
> Created attachment 302661 [details]
> Patch

Tests failed; uploaded same patch to see if it is consistent.
Comment 8 Maciej Stachowiak 2020-05-30 19:11:28 PDT 
Comment on attachment 302661 [details]
Patch

Seems like a decent cleanup, and shockingly this old patch still applies. r=me
Comment 9 Per Arne Vollan 2020-06-01 06:36:56 PDT 
Comment on attachment 302661 [details]
Patch

Thanks for reviewing!
Comment 10 EWS 2020-06-01 06:56:56 PDT 
Committed r262376: <https://trac.webkit.org/changeset/262376>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 302661 [details].
Comment 11 Radar WebKit Bug Importer 2020-06-01 06:57:16 PDT 
<rdar://problem/63828150>