Bug 168649 – Relax Request constructor around referrers

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Anne van Kesteren]

See https://github.com/whatwg/fetch/pull/377 for the change to the standard.

http://w3c-test.org/fetch/api/policies/referrer-origin.html has a test, but please read https://github.com/w3c/web-platform-tests/issues/2618 for why the first test fails there (and the second test might too I suppose).

[Rob Buis]

Created attachment 347456 [details]
Patch

[EWS Watchlist]

Comment on attachment 347456 [details]
Patch

Attachment 347456 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8908117

New failing tests:
legacy-animation-engine/imported/blink/transitions/unprefixed-transform.html

[EWS Watchlist]

Created attachment 347457 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Darin Adler]

Comment on attachment 347456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347456&action=review

> Source/WebCore/Modules/fetch/FetchRequest.cpp:62
> -        return Exception { TypeError, "Referrer is not same-origin."_s };
> +        return String { "client" };

This, and the code above, should be using String { "client"_s } so we get the ASCIILiteral optimization. Same for "no-referrer"_s.

[Rob Buis]

Created attachment 347486 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 347486 [details]
Patch

Clearing flags on attachment: 347486

Committed r235025: <https://trac.webkit.org/changeset/235025>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/43534512>