Bug 168646 - AudioSampleDataSource should not exclusively lock its read and write threads.
Summary: AudioSampleDataSource should not exclusively lock its read and write threads.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-21 00:36 PST by Jer Noble
Modified: 2017-02-27 09:07 PST (History)
0 users

See Also:

Attachments
Patch (5.77 KB, patch)
2017-02-21 00:39 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (5.76 KB, patch)
2017-02-21 10:13 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (5.76 KB, patch)
2017-02-21 14:32 PST, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2017-02-21 00:36:55 PST 
AudioSampleDataSource should not exclusively lock its read and write threads.
Comment 1 Jer Noble 2017-02-21 00:39:01 PST 
Created attachment 302242 [details]
Patch
Comment 2 Jer Noble 2017-02-21 10:13:48 PST 
Created attachment 302276 [details]
Patch
Comment 3 Jer Noble 2017-02-21 14:32:15 PST 
Created attachment 302309 [details]
Patch
Comment 4 youenn fablet 2017-02-24 08:15:43 PST 
Comment on attachment 302309 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302309&action=review

> Source/WebCore/ChangeLog:11
> +        CARingBuffer to safely and simultaneously read and write data.

Makes sense to me.
I can't find any unit test checking CARingBuffer behavior in multithreading though.
Would it be useful to ensure CARingBuffer and/or AudioSampleDataSource are working as expected though some unit tests?
Comment 5 Jer Noble 2017-02-27 09:07:06 PST 
Committed r213072: <http://trac.webkit.org/changeset/213072>