Bug 168641 - Give the Mock audio input a "hum" to make drop-outs more detectable
Summary: Give the Mock audio input a "hum" to make drop-outs more detectable
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-20 23:08 PST by Jer Noble
Modified: 2017-02-21 17:46 PST (History)
2 users (show)

See Also:

Attachments
Patch (7.96 KB, patch)
2017-02-20 23:28 PST, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (7.97 KB, patch)
2017-02-21 09:40 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2017-02-20 23:08:29 PST 
Give teh Mock audio input a "hum" to make drop-outs more detectable
Comment 1 Jer Noble 2017-02-20 23:28:13 PST 
Created attachment 302235 [details]
Patch
Comment 2 Jer Noble 2017-02-21 09:40:02 PST 
Created attachment 302272 [details]
Patch for landing
Comment 3 WebKit Commit Bot 2017-02-21 10:30:32 PST 
Comment on attachment 302272 [details]
Patch for landing

Clearing flags on attachment: 302272

Committed r212725: <http://trac.webkit.org/changeset/212725>
Comment 4 Simon Fraser (smfr) 2017-02-21 17:32:59 PST 
Why is there no test, especially when I would expect the Mock Audio Input to affect tests?
Comment 5 Jer Noble 2017-02-21 17:45:39 PST 
(In reply to comment #4)
> Why is there no test, especially when I would expect the Mock Audio Input to
> affect tests?

We don't have any way to capture audio data for testing.  When we hook up MediaStreams to Web Audio we may eventually have some way of testing this, but that code path isn't implemented yet.
Comment 6 Jer Noble 2017-02-21 17:46:43 PST 
(In reply to comment #5)
> (In reply to comment #4)
> > Why is there no test, especially when I would expect the Mock Audio Input to
> > affect tests?
> 
> We don't have any way to capture audio data for testing.  When we hook up
> MediaStreams to Web Audio we may eventually have some way of testing this,
> but that code path isn't implemented yet.

And no, this doesn't affect tests, since no test yet depends on the actual /content/ of the audio stream.  This change was just for analog/eardrum testing purposes.