Bug 168641 – Give the Mock audio input a "hum" to make drop-outs more detectable

• Status: NEW
• Component: New Bugs

[Jer Noble]

Give teh Mock audio input a "hum" to make drop-outs more detectable

[Jer Noble]

Created attachment 302235 [details]
Patch

[Jer Noble]

Created attachment 302272 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 302272 [details]
Patch for landing

Clearing flags on attachment: 302272

Committed r212725: <http://trac.webkit.org/changeset/212725>

[Simon Fraser (smfr)]

Why is there no test, especially when I would expect the Mock Audio Input to affect tests?

[Jer Noble]

(In reply to comment #4)
> Why is there no test, especially when I would expect the Mock Audio Input to
> affect tests?

We don't have any way to capture audio data for testing.  When we hook up MediaStreams to Web Audio we may eventually have some way of testing this, but that code path isn't implemented yet.

[Jer Noble]

(In reply to comment #5)
> (In reply to comment #4)
> > Why is there no test, especially when I would expect the Mock Audio Input to
> > affect tests?
> 
> We don't have any way to capture audio data for testing.  When we hook up
> MediaStreams to Web Audio we may eventually have some way of testing this,
> but that code path isn't implemented yet.

And no, this doesn't affect tests, since no test yet depends on the actual /content/ of the audio stream.  This change was just for analog/eardrum testing purposes.