Bug 168640 - AudioSampleDataSource doesn't need to use the m_scratchBuffer on the pulling thread
Summary: AudioSampleDataSource doesn't need to use the m_scratchBuffer on the pulling ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-20 23:06 PST by Jer Noble
Modified: 2017-02-21 15:20 PST (History)
1 user (show)

See Also:

Attachments
Patch (2.27 KB, patch)
2017-02-20 23:07 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (2.21 KB, patch)
2017-02-21 11:07 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2017-02-20 23:06:07 PST 
AudioSampleDataSource doesn't need to use the m_scratchBuffer on the pulling thread
Comment 1 Jer Noble 2017-02-20 23:07:34 PST 
Created attachment 302234 [details]
Patch
Comment 2 Jer Noble 2017-02-21 11:07:19 PST 
Created attachment 302286 [details]
Patch
Comment 3 Eric Carlson 2017-02-21 11:48:44 PST 
Comment on attachment 302286 [details]
Patch

As we discussed, this isn't correct in the case where the ring buffer data is supposed to be mixed into the output, but the existing code is equally incorrect so I will file a new bug to fix that.
Comment 4 WebKit Commit Bot 2017-02-21 15:20:22 PST 
Comment on attachment 302286 [details]
Patch

Clearing flags on attachment: 302286

Committed r212771: <http://trac.webkit.org/changeset/212771>
Comment 5 WebKit Commit Bot 2017-02-21 15:20:26 PST 
All reviewed patches have been landed.  Closing bug.