Bug 168638 - Parsing -webkit-hyphenate-character uses confusingly named consumeLocale()
Summary: Parsing -webkit-hyphenate-character uses confusingly named consumeLocale()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-20 22:53 PST by Simon Fraser (smfr)
Modified: 2017-03-07 19:15 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.10 KB, patch)
2017-03-07 18:30 PST, Simon Fraser (smfr) 		zalan: review+
zalan: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2017-02-20 22:53:42 PST 
-webkit-hyphenate-character was implemented in http://trac.webkit.org/r61548 parsing as <auto> or a string, but now we just fall through to parsing a locale:

CSSPropertyParser.cpp:3761
    case CSSPropertyWebkitHyphenateCharacter:
    case CSSPropertyWebkitLocale:
        return consumeLocale(m_range);
Comment 1 Simon Fraser (smfr) 2017-02-20 22:55:14 PST 
https://www.w3.org/TR/css-text-4/#hyphenate-character
Comment 2 Simon Fraser (smfr) 2017-02-21 11:53:43 PST 
It's just bad function naming.
Comment 3 Simon Fraser (smfr) 2017-03-07 18:30:58 PST 
Created attachment 303756 [details]
Patch
Comment 4 zalan 2017-03-07 18:44:52 PST 
Comment on attachment 303756 [details]
Patch

title is misleading.
Comment 5 Simon Fraser (smfr) 2017-03-07 19:15:24 PST 
https://trac.webkit.org/r213561