Bug 168635 - AudioSampleBufferList::zeroABL() takes a byte-count, not a sample-count.
Summary: AudioSampleBufferList::zeroABL() takes a byte-count, not a sample-count.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-20 22:12 PST by Jer Noble
Modified: 2022-10-10 14:24 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.75 KB, patch)
2017-02-20 22:33 PST, Jer Noble 		jonlee: review+
Details | Formatted Diff | Diff
Patch for landing (3.73 KB, patch)
2017-02-21 08:34 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2017-02-20 22:12:49 PST 
AudioSampleBufferList::zeroABL() takes a byte-count, not a sample-count.
Comment 1 Jer Noble 2017-02-20 22:33:37 PST 
Created attachment 302232 [details]
Patch
Comment 2 Jon Lee 2017-02-21 00:22:17 PST 
Comment on attachment 302232 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302232&action=review

> Source/WebCore/ChangeLog:10
> +        (WebCore::AudioSampleDataSource::pullAvalaibleSamplesAsChunks):

Weird that it didn't pick up pullSamples instead. And also, terrible spelling of Available.
Comment 3 Jer Noble 2017-02-21 08:34:25 PST 
Created attachment 302264 [details]
Patch for landing
Comment 4 Jer Noble 2017-02-21 08:56:22 PST 
(In reply to comment #2)
> Comment on attachment 302232 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=302232&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        (WebCore::AudioSampleDataSource::pullAvalaibleSamplesAsChunks):
> 
> Weird that it didn't pick up pullSamples instead. And also, terrible
> spelling of Available.

Yeah, I think that when a function is too short, the function detector freaks out and picks the previous one.
Comment 5 WebKit Commit Bot 2017-02-21 09:20:55 PST 
Comment on attachment 302264 [details]
Patch for landing

Clearing flags on attachment: 302264

Committed r212714: <http://trac.webkit.org/changeset/212714>
Comment 6 Simon Fraser (smfr) 2017-02-21 17:34:05 PST 
Why is there no test?
Comment 7 Simon Fraser (smfr) 2017-02-21 17:34:38 PST 
Comment on attachment 302264 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=302264&action=review

> Source/WebCore/ChangeLog:10
> +        (WebCore::AudioSampleDataSource::pullAvalaibleSamplesAsChunks):

Speling.
Comment 8 Jer Noble 2017-02-21 17:40:19 PST 
(In reply to comment #6)
> Why is there no test?

We don't have any test infrastructure for inspecting rendered audio.
Comment 9 Simon Fraser (smfr) 2017-02-21 18:03:42 PST 
Doesn't web audio have something?
Comment 10 Ahmad Saleem 2022-10-10 14:23:45 PDT 
https://github.com/WebKit/WebKit/commit/661e7be6621f71f2f55632903c62ad69591dd11d

Landed and didn't backed out. Marking this as "RESOLVED FIXED".
Comment 11 Radar WebKit Bug Importer 2022-10-10 14:24:21 PDT 
<rdar://problem/100997360>