Bug 168634 - [Xcode] libwebrtc installhdrs doesn’t install any of the headers
Summary: [Xcode] libwebrtc installhdrs doesn’t install any of the headers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-20 22:03 PST by mitz
Modified: 2017-02-21 15:26 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.06 KB, patch)
2017-02-21 07:33 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (3.21 KB, patch)
2017-02-21 09:24 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2017-02-20 22:03:00 PST 
libwebrtc’s installhdrs action doesn’t install any of its headers. It looks like the install action installs headers via a script build phase in the “Copy webrtc headers” target, but that target doesn’t have INSTALLHDRS_SCRIPT_PHASE set to YES.
Comment 1 youenn fablet 2017-02-21 07:33:10 PST 
Created attachment 302258 [details]
Patch
Comment 2 mitz 2017-02-21 08:04:38 PST 
Comment on attachment 302258 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302258&action=review

> Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig:13
> +INSTALLHDRS_COPY_PHASE = YES;

Can you explain what this is for?
Comment 3 mitz 2017-02-21 08:10:56 PST 
Comment on attachment 302258 [details]
Patch

Can you explain how libwebrtc.xcconfig affects the “Copy webrtc headers” target? My reading of the project file is that that configuration settings file is not used for that target. Does this patch actually fix the bug?
Comment 4 youenn fablet 2017-02-21 08:14:55 PST 
Let me check further.
Comment 5 youenn fablet 2017-02-21 09:24:35 PST 
Created attachment 302271 [details]
Patch
Comment 6 Alex Christensen 2017-02-21 15:25:40 PST 
Comment on attachment 302271 [details]
Patch

http://trac.webkit.org/r212772
Comment 7 Alex Christensen 2017-02-21 15:26:14 PST 
Comment on attachment 302271 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302271&action=review

> Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig:13
> +INSTALLHDRS_COPY_PHASE = YES;

What I committed has INSTALLHDRS_SCRIPT_PHASE = YES instead of this.