Bug 168620 - Add support to PlatformCALayer/GraphicsLayerCA for subpixel-antialiased text, with a Setting and a MiniBrowser switch
Summary: Add support to PlatformCALayer/GraphicsLayerCA for subpixel-antialiased text,...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-20 16:10 PST by Simon Fraser (smfr)
Modified: 2017-02-21 16:32 PST (History)
5 users (show)

See Also:

Attachments
Patch (51.50 KB, patch)
2017-02-20 16:16 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (55.16 KB, patch)
2017-02-20 16:34 PST, Simon Fraser (smfr) 		thorton: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews113 for mac-elcapitan (1.75 MB, application/zip)
2017-02-20 18:27 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews101 for mac-elcapitan (1.04 MB, application/zip)
2017-02-20 19:26 PST, Build Bot 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2017-02-20 16:10:48 PST 
Add support to PlatformCALayer/GraphicsLayerCA for subpixel-antialiased text, with a Setting and a MiniBrowser switch
Comment 1 Simon Fraser (smfr) 2017-02-20 16:16:15 PST 
Created attachment 302195 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2017-02-20 16:16:34 PST 
<rdar://problem/30617772>
Comment 3 Simon Fraser (smfr) 2017-02-20 16:34:20 PST 
Created attachment 302200 [details]
Patch
Comment 4 Tim Horton 2017-02-20 16:50:27 PST 
Comment on attachment 302200 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302200&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:747
> +#if PLATFORM(MAC)

Why #if?
Comment 5 Build Bot 2017-02-20 18:27:18 PST 
Comment on attachment 302200 [details]
Patch

Attachment 302200 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3162443

New failing tests:
compositing/contents-format/subpixel-antialiased-text-enabled.html
Comment 6 Build Bot 2017-02-20 18:27:20 PST 
Created attachment 302214 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 7 Build Bot 2017-02-20 19:26:36 PST 
Comment on attachment 302200 [details]
Patch

Attachment 302200 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3162747

New failing tests:
compositing/contents-format/subpixel-antialiased-text-enabled.html
Comment 8 Build Bot 2017-02-20 19:26:39 PST 
Created attachment 302219 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 9 Simon Fraser (smfr) 2017-02-21 16:32:56 PST 
https://trac.webkit.org/r212776